From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH] ASoC: adau1701: Initialize codec->control_data before using it Date: Wed, 28 Sep 2011 09:26:44 +0200 Message-ID: <4E82CC34.10204@metafoo.de> References: <1317194488.2498.2.camel@phoenix> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-141.synserver.de (smtp-out-142.synserver.de [212.40.185.142]) by alsa0.perex.cz (Postfix) with SMTP id 23978103A0E for ; Wed, 28 Sep 2011 09:27:05 +0200 (CEST) In-Reply-To: <1317194488.2498.2.camel@phoenix> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Axel Lin Cc: alsa-devel@alsa-project.org, Mark Brown , linux-kernel@vger.kernel.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org On 09/28/2011 09:21 AM, Axel Lin wrote: > Currently codec->control_data is not initialized before calling > process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE). > > Signed-off-by: Axel Lin Acked-by: Lars-Peter Clausen Thanks > --- > sound/soc/codecs/adau1701.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c > index b7e4cc7..8b7e1c5 100644 > --- a/sound/soc/codecs/adau1701.c > +++ b/sound/soc/codecs/adau1701.c > @@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec) > int ret; > > codec->dapm.idle_bias_off = 1; > + codec->control_data = to_i2c_client(codec->dev); > > ret = adau1701_load_firmware(codec); > if (ret) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753462Ab1I1H1I (ORCPT ); Wed, 28 Sep 2011 03:27:08 -0400 Received: from smtp-out-142.synserver.de ([212.40.185.142]:1110 "HELO smtp-out-141.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1751433Ab1I1H1H (ORCPT ); Wed, 28 Sep 2011 03:27:07 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@laprican.de X-SynServer-PPID: 17405 Message-ID: <4E82CC34.10204@metafoo.de> Date: Wed, 28 Sep 2011 09:26:44 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110818 Icedove/3.0.11 MIME-Version: 1.0 To: Axel Lin CC: linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org Subject: Re: [PATCH] ASoC: adau1701: Initialize codec->control_data before using it References: <1317194488.2498.2.camel@phoenix> In-Reply-To: <1317194488.2498.2.camel@phoenix> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/28/2011 09:21 AM, Axel Lin wrote: > Currently codec->control_data is not initialized before calling > process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE). > > Signed-off-by: Axel Lin Acked-by: Lars-Peter Clausen Thanks > --- > sound/soc/codecs/adau1701.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c > index b7e4cc7..8b7e1c5 100644 > --- a/sound/soc/codecs/adau1701.c > +++ b/sound/soc/codecs/adau1701.c > @@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec) > int ret; > > codec->dapm.idle_bias_off = 1; > + codec->control_data = to_i2c_client(codec->dev); > > ret = adau1701_load_firmware(codec); > if (ret)