All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory
Date: Wed, 28 Sep 2011 10:00:44 +0200	[thread overview]
Message-ID: <4E82D42C.2070607@redhat.com> (raw)
In-Reply-To: <4E82D238.8040206@siemens.com>

On 09/28/2011 09:52 AM, Jan Kiszka wrote:
> >  You can probably assume that qemu_notify_event (and dually the read in
> >  the main loop) are resp. write/read memory barriers.  Or even full.
> >
> >  If we switch entirely to GSources, it would be nice to use them.  But
> >  since we aren't, and our main loop functionality is quite different from
> >  glib's (it doesn't rely on abstractions for file descriptors, for
> >  example), it is just a painful incomplete transition to use glib's idle
> >  sources to do the exact same thing that is done by bottom halves (which
> >  are already in our toolbox).
>
> BTW, I just wondered if there is anything conceptually preventing to
> skip this ping pong between AIO thread and main loop and just run the
> completion over the former context (under global lock protection of course).

Would be a good idea, but it would require some refactoring because 
tools do not have a global lock.

Paolo

  reply	other threads:[~2011-09-28  8:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 14:26 [Qemu-devel] [PATCH] event_notifier: move to top-level directory Avi Kivity
2011-09-27 15:17 ` Stefan Hajnoczi
2011-09-27 15:28   ` Jan Kiszka
2011-09-27 16:05     ` Anthony Liguori
2011-09-27 16:39       ` Paolo Bonzini
2011-09-27 21:23         ` Anthony Liguori
2011-09-28  6:27           ` Paolo Bonzini
2011-09-28  7:52             ` Jan Kiszka
2011-09-28  8:00               ` Paolo Bonzini [this message]
2011-09-28  9:12           ` Stefan Hajnoczi
2011-11-01 22:18 ` Anthony Liguori
2011-11-02 18:10   ` Alexander Graf
2011-11-02 17:12     ` Avi Kivity
2011-11-02 17:13       ` Avi Kivity
2011-11-02 18:23         ` Alexander Graf
2011-11-02 17:22           ` Avi Kivity
2011-11-02 17:27             ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E82D42C.2070607@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.