From: "Andreas Färber" <andreas.faerber@web.de>
To: khansa@kics.edu.pk
Cc: peter.maydell@linaro.org, riku.voipio@iki.fi,
qemu-devel@nongnu.org, aurelien@aurel32.net, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions
Date: Wed, 28 Sep 2011 10:29:18 +0200 [thread overview]
Message-ID: <4E82DADE.7050909@web.de> (raw)
In-Reply-To: <1317097027-23748-6-git-send-email-khansa@kics.edu.pk>
Am 27.09.2011 06:17, schrieb khansa@kics.edu.pk:
> From: Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt <khansa@kics.edu.pk>
>
>
> Signed-off-by: Khansa Butt <khansa@kics.edu.pk>
...nor all of mine from previous rounds. Including From vs.
Signed-off-by mixup (From is who sent the patch, not whom the code
originated from), Coding Style issues, misleading "Cavium specific"
comments, typos, ...
A space after the colon in the subject would be more visually pleasing, too.
Further, your patch series is completely missing versioning ([PATCH vX
n/m] and change log). Not seeing what you've actually changed for this
resubmission while still seeing unaddressed flaws we've pointed out
already becomes annoying after a while and will not help your patches
make it into the repository...
Regards,
Andreas
next prev parent reply other threads:[~2011-09-28 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 4:17 [Qemu-devel] [PATCH 0/7] MIPS64 user mode emulation in QEMU with Cavium specific instruction support khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 1/7] linux-user:Support for MIPS64 user mode emulation in QEMU khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 2/7] target-mips:enabling of 64 bit user mode and floating point operations khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 3/7] linux-user:Signal handling for MIPS64 khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 4/7] target-mips:Octeon cpu definition khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions khansa
2011-09-27 15:14 ` Richard Henderson
2011-09-28 8:29 ` Andreas Färber [this message]
2011-09-27 4:17 ` [Qemu-devel] [PATCH 6/7] Addition of Cavium instructions in disassembler khansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E82DADE.7050909@web.de \
--to=andreas.faerber@web.de \
--cc=aurelien@aurel32.net \
--cc=khansa@kics.edu.pk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.