All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Richard Henderson <rth@twiddle.net>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers
Date: Wed, 28 Sep 2011 16:33:51 +0200	[thread overview]
Message-ID: <4E83304F.4010008@siemens.com> (raw)
In-Reply-To: <4E832E88.6080909@twiddle.net>

On 2011-09-28 16:26, Richard Henderson wrote:
> On 09/28/2011 05:28 AM, Jan Kiszka wrote:
>> +#if TCG_TARGET_REG_BITS == 64
>> +    { INDEX_op_deposit8l_i32, { "r", "0", "r" } },
>> +#else
>> +    { INDEX_op_deposit8l_i32, { "abcd", "0", "abcd" } },
>> +#endif
>
> At minimum, abcd is spelled "q".

Ah, perfect.

>
> I don't particularly care for the 3 different opcodes.  Perhaps
> we'd be better off with an inline predicate for when the deposit
> opcode is "valid"?

We still need to dispatch at tcg generation time which variant is valid. 
Or what do you have in mind?

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2011-09-28 14:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 12:28 [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers Jan Kiszka
2011-09-28 14:26 ` Richard Henderson
2011-09-28 14:33   ` Jan Kiszka [this message]
2011-09-28 15:19     ` Richard Henderson
2011-09-28 22:07       ` Jan Kiszka
2011-09-28 22:47         ` Richard Henderson
2011-09-29 11:31           ` [Qemu-devel] [PATCH v2] tcg-i386: Introduce limited deposit support Jan Kiszka
2011-09-29 14:58             ` Richard Henderson
2011-09-29 15:19               ` Jan Kiszka
2011-09-29 15:23                 ` [Qemu-devel] [PATCH v3] " Jan Kiszka
2011-09-29 16:11                   ` Richard Henderson
2011-09-29 16:52                     ` [Qemu-devel] [PATCH v4] " Jan Kiszka
2011-09-29 19:50                       ` Richard Henderson
2011-10-01 12:06                       ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E83304F.4010008@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.