All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <david.daney@cavium.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	davem@davemloft.net
Subject: Re: [PATCH v2 2/3] netdev/of/phy: Add MDIO bus multiplexer support.
Date: Wed, 28 Sep 2011 09:51:52 -0700	[thread overview]
Message-ID: <4E8350A8.7090307@cavium.com> (raw)
In-Reply-To: <CAHXqBFLzrkH4AJVozbtT4k7ccgVgfaPoq69J48DeSJKSwEtxHw@mail.gmail.com>

On 09/28/2011 12:25 AM, Michał Mirosław wrote:
> 2011/9/28 David Daney<david.daney@cavium.com>:
> [...]
>> +Example :
>> +
>> +       /* The parent MDIO bus. */
>> +       smi1: mdio@1180000001900 {
>> +               compatible = "cavium,octeon-3860-mdio";
>> +               #address-cells =<1>;
>> +               #size-cells =<0>;
>> +               reg =<0x11800 0x00001900 0x0 0x40>;
>> +       };
>> +
>> +       /*
>> +          An NXP sn74cbtlv3253 dual 1-of-4 switch controlled by a
>> +          pair of GPIO lines.  Child busses 2 and 3 populated with 4
>> +          PHYs each.
>> +        */
>> +       mdio-mux {
>> +               compatible = "cavium,mdio-mux-sn74cbtlv3253", "cavium,mdio-mux";
>> +               gpios =<&gpio1 3 0>,<&gpio1 4 0>;
>> +               mdio-parent-bus =<&smi1>;
>> +               #address-cells =<1>;
>> +               #size-cells =<0>;
>
> This should probably have 'compatible = "nxp,sn74cbtlv3253";' here.
>

No, the sn74cbtlv3253 is a general purpose part that could be used to 
multiplex anything (I2C, SPI, random analog signals, etc.).  Only when 
it is in the "cavium,mdio-mux-sn74cbtlv3253" configuration is it an MDIO 
bus multiplexer.

David Daney.

  reply	other threads:[~2011-09-28 16:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 23:26 [PATCH v2 0/3] netdev/of/phy: MDIO bus multiplexer support David Daney
2011-09-27 23:26 ` David Daney
2011-09-27 23:26 ` [PATCH v2 1/3] netdev/of/phy: New function: of_mdio_find_bus() David Daney
2011-09-29 21:41   ` Grant Likely
2011-09-27 23:26 ` [PATCH v2 2/3] netdev/of/phy: Add MDIO bus multiplexer support David Daney
2011-09-27 23:26   ` David Daney
2011-09-28  7:25   ` Michał Mirosław
2011-09-28  7:25     ` Michał Mirosław
2011-09-28 16:51     ` David Daney [this message]
2011-09-28 17:32       ` Michał Mirosław
2011-09-28 17:42         ` David Daney
2011-09-29 21:56   ` Grant Likely
2011-09-27 23:26 ` [PATCH v2 3/3] netdev/of/phy: Add MDIO bus multiplexer driven by GPIO lines David Daney
2011-09-27 23:26   ` David Daney
2011-09-29 22:01   ` Grant Likely
2011-09-29 22:01     ` Grant Likely
2011-09-29 20:31 ` [PATCH v2 0/3] netdev/of/phy: MDIO bus multiplexer support David Miller
2011-09-30  0:32   ` Grant Likely
2011-10-17 14:48     ` Kumar Gala
2011-10-17 14:48       ` Kumar Gala
2011-10-17 15:41       ` David Daney
2012-04-13 19:08         ` Andy Fleming
2012-04-13 19:51           ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8350A8.7090307@cavium.com \
    --to=david.daney@cavium.com \
    --cc=davem@davemloft.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirqus@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.