From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lon Hohberger Date: Wed, 28 Sep 2011 16:30:17 -0400 Subject: [Cluster-devel] [PATCH 2/3] dlm_controld: full check for member changes In-Reply-To: <1317227848-8323-2-git-send-email-teigland@redhat.com> References: <1317227848-8323-2-git-send-email-teigland@redhat.com> Message-ID: <4E8383D9.2040009@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 09/28/2011 12:37 PM, David Teigland wrote: > cman members are queried in response to a callback, > and members sometimes leave and rejoin between queries > (e.g. when they leave and rejoin before corosync > detects they left.) > > This means that simply checking if a node is a member > in consecutive queries sometimes misses events. We > need to compare the incarnation numbers of members > from consecutive queries to avoid this. I was confused initially by the static ringid seq since its contents are only used in the statechange() function, but it's consistent with other variables and is useful for debugging, so ACK. -- Lon