From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R91WR-0007Af-6v
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 17:18:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R91WQ-00070K-1i
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 17:18:31 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:45930)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R91WP-0006zo-Ry
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 17:18:30 -0400
Message-ID: <4E838F0B.2010900@web.de>
Date: Wed, 28 Sep 2011 23:18:03 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <cover.1317207666.git.jan.kiszka@siemens.com>
	<bcaf89ca8b39b60707d5d3b3f4fa4d2dbd56ffb6.1317207666.git.jan.kiszka@siemens.com>
	<CAAu8pHv+UfBP7d4q=CnhisSoNRscKLFqfxBQm84fi18Rxkdi+Q@mail.gmail.com>
In-Reply-To: <CAAu8pHv+UfBP7d4q=CnhisSoNRscKLFqfxBQm84fi18Rxkdi+Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: jan.kiszka@web.de
Subject: Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On 2011-09-28 20:01, Blue Swirl wrote:
> On Wed, Sep 28, 2011 at 11:00 AM, Jan Kiszka<jan.kiszka@siemens.com>  wrote:
>> As we clearly modify the PIC state on pic_reset, we also have to update
>> the IRQ output. This only happened on init so far. Apply this
>> consistently.
>
> Nack, IRQ lines shouldn't be touched on reset. The other side may not
> be ready for receiving the interrupt change and qemu_irqs are
> stateless anyway.

Sorry, but failing to clear the line (this is what pic_update_irq will 
effectively do) is a clear bug in the current code. This patch is 100% 
analogue to what, e.g. the PCI layer does on reset. Please re-read.

Jan