From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1R91qs-0006AJ-35 for mharc-grub-devel@gnu.org; Wed, 28 Sep 2011 17:39:38 -0400 Received: from eggs.gnu.org ([140.186.70.92]:48142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R91qo-00069E-FY for grub-devel@gnu.org; Wed, 28 Sep 2011 17:39:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R91ql-0004sK-PL for grub-devel@gnu.org; Wed, 28 Sep 2011 17:39:34 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:51274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R91ql-0004s6-6J for grub-devel@gnu.org; Wed, 28 Sep 2011 17:39:31 -0400 Received: by fxh17 with SMTP id 17so1293294fxh.0 for ; Wed, 28 Sep 2011 14:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=4yRD93HqO4XJvSj5sRXw7x/xnC9eAA6CIkeHX/wAWXM=; b=XgFztKFP0AltcftWxtfejynZ5aBQl1H2sq/eai/dKXaveAIiW+ITknI1zoxO88ZxEH CtwiEO1/qnwHU9My/KcA+5Q0POSuoyWTvkAQxhHTKHIrO9+Ej5Dnnnnu4VW10OZNFSU6 ED2OsEQZyAedlS8uoHE/U7SZVOVdPY95TFYNI= Received: by 10.223.47.207 with SMTP id o15mr4439432faf.88.1317245970001; Wed, 28 Sep 2011 14:39:30 -0700 (PDT) Received: from debian.x201.phnet (67-232.197-178.cust.bluewin.ch. [178.197.232.67]) by mx.google.com with ESMTPS id a1sm148778fab.4.2011.09.28.14.39.26 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 28 Sep 2011 14:39:27 -0700 (PDT) Message-ID: <4E83940C.8060601@gmail.com> Date: Wed, 28 Sep 2011 23:39:24 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [RFC] LZO support References: <201109142120.06740.szymon@janc.net.pl> In-Reply-To: <201109142120.06740.szymon@janc.net.pl> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig69D4BA0C8DABF7F319EBAE8D" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2011 21:39:36 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig69D4BA0C8DABF7F319EBAE8D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 14.09.2011 21:20, Szymon Janc wrote: > Hello, > > I've implemented support for LZO in grub, this includes: > - import of minilzo library (from [1]) > - support for LZO (de)compression in btrfs (compress=3Dlzo mount option= ) > - lzopio - for reading lzop compressed files > + common =3D lib/minilzo/minilzo.c; @@ -1650,6 +1653,14 @@ + common =3D lib/minilzo/minilzo.c; Please don't include same file twice in different modules it creates a symbol conflict. It's ok to have btrfs depend on lzopio if necessary, at least for now. +#include "minilzo.h" I'd prefer and an explicit -I on cppflags if necessary. - grub_disk_addr_t *outaddr, grub_size_t *outsize, + grub_disk_addr_t * outaddr, grub_size_t * outsize, this is a stylistic regression. (several such occurences) - if (desc->data[desc->depth - 1].iter - < desc->data[desc->depth - 1].maxiter) + if (desc->data[desc->depth - 1].iter < + desc->data[desc->depth - 1].maxiter) Likewise. + grub_uint8_t context[lzopio->ccheck_fun->contextsize]; This isn't necessarily well-aligned. Use grub_uint64_t context[(lzopio->ccheck_fun->contextsize + 7) / 8]; (several occurences) + file->size =3D GRUB_FILE_SIZE_UNKNOWN; Several components have trouble with such files. Is there any way to retrieve the size of lzio compressed file? > - lzopio works ok with grub-fstest (crc, testload), also able to load m= odules=20 > compressed with lzop, but compressing all modules and doing=20 > grub-install --modules=3Dlzopio fails to boot, still need to investig= ate that That because dependencies on hashes are soft so it's not correctly tracked by grub-install and so you end up in an infinite recursion. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig69D4BA0C8DABF7F319EBAE8D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk6DlAwACgkQNak7dOguQgngJAD/b9wWY05HOchCxeUINviObItO hTMZA4hlsWpiJMrwPJQBAIEVUZ2VfY7u1ZKn0UyVlsKhAYWzS8IwhbZL6C0j9OqZ =76cd -----END PGP SIGNATURE----- --------------enig69D4BA0C8DABF7F319EBAE8D--