From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1R92ZA-0003uE-50
	for mharc-grub-devel@gnu.org; Wed, 28 Sep 2011 18:25:24 -0400
Received: from eggs.gnu.org ([140.186.70.92]:40906)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gregoire.sutre@gmail.com>) id 1R92Z8-0003u8-KB
	for grub-devel@gnu.org; Wed, 28 Sep 2011 18:25:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gregoire.sutre@gmail.com>) id 1R92Z7-0004Qi-Hy
	for grub-devel@gnu.org; Wed, 28 Sep 2011 18:25:22 -0400
Received: from mail-ww0-f49.google.com ([74.125.82.49]:51870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gregoire.sutre@gmail.com>) id 1R92Z7-0004QU-DN
	for grub-devel@gnu.org; Wed, 28 Sep 2011 18:25:21 -0400
Received: by wwp14 with SMTP id 14so83304wwp.30
	for <grub-devel@gnu.org>; Wed, 28 Sep 2011 15:25:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=message-id:date:from:user-agent:mime-version:to:subject:references
	:in-reply-to:content-type:content-transfer-encoding;
	bh=Mtf0WnfONer/QnNr4vynz8K35Wgqg5UmgrD03gAGgSA=;
	b=X1mTCCudhG1jOYI/BE6FyoHZi5dlLoNKoD/Kg3M1yZ0UY4C3FbYMvuhplWSY3F05qW
	6pjioo9pHhEMpOy8HU11sKtNmBAV9RIQmqACDS9Uar20k1xOkv8uvLIXIZS7uWcB7mGg
	J9pQC9N+A6oU5YHPQ+l2PXpgqy/Z1/kSjJZo0=
Received: by 10.216.192.35 with SMTP id h35mr339104wen.9.1317248720553;
	Wed, 28 Sep 2011 15:25:20 -0700 (PDT)
Received: from [192.168.1.37] (c2433-1-88-160-112-182.fbx.proxad.net.
	[88.160.112.182])
	by mx.google.com with ESMTPS id gd6sm332019wbb.1.2011.09.28.15.25.19
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 28 Sep 2011 15:25:19 -0700 (PDT)
Message-ID: <4E839ECF.8070509@gmail.com>
Date: Thu, 29 Sep 2011 00:25:19 +0200
From: =?UTF-8?B?R3LDqWdvaXJlIFN1dHJl?= <gregoire.sutre@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13
MIME-Version: 1.0
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [patch] Make knetbsd pass the root device
References: <4E7920D0.3090401@gmail.com> <4E835FC3.90307@gmail.com>
	<4E838A23.4080107@gmail.com>
In-Reply-To: <4E838A23.4080107@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 74.125.82.49
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Sep 2011 22:25:23 -0000

On 09/28/2011 10:57 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 28.09.2011 19:56, Grégoire Sutre wrote:
>> +  grub_uint64_t buf[(GRUB_DISK_SECTOR_SIZE + 7) / 8];
> No need for + 7 since you know that GRUB_DISK_SECTOR_SIZE is divisible
> by 8. Other than this patch looks good. Go ahead

Thanks, committed.

 > (I assume that you checked that it works well with NetBSD)

I made a number of tests, with various partitioning schemes,
mainly with NetBSD -current, but I also made a few with the
latest stable release.

Grégoire