From: Larry Finger <Larry.Finger@lwfinger.net>
To: Borislav Petkov <bp@alien8.de>
Cc: 李朝明 <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org,
'LKML' <linux-kernel@vger.kernel.org>
Subject: Re: 答复: 答复: 答复: 3.1-rc6+ rtl8192se issue
Date: Wed, 28 Sep 2011 20:57:38 -0500 [thread overview]
Message-ID: <4E83D092.7010405@lwfinger.net> (raw)
In-Reply-To: <20110928131823.GA2693@gere.osrc.amd.com>
On 09/28/2011 08:18 AM, Borislav Petkov wrote:
> On Fri, Sep 23, 2011 at 11:34:12AM -0500, Larry Finger wrote:
>> On 09/23/2011 05:33 AM, Borislav Petkov wrote:
>>> On Fri, Sep 23, 2011 at 06:21:07PM +0800, 李朝明 wrote:
>>>> Please set ips =0 and try again..
>>>
>>> What does that mean?
>>>
>>> I can trigger the grinding-to-a-halt reliably with "ips=0" - it only
>>> takes a couple of hours of network traffic. Also, I don't want to try
>>> the driver you sent me because the version in the kernel needs fixing
>>> not some out-of-tree codebase.
>>
>> I got a chance to review the rtl8192se part of the changes in that
>> 08/16/2011 version. Attached is a patch to update the kernel
>> version.
>>
>> A prerequisite is:
>>
>> commit da3ba88a9996cd64c6768bed5727e02da81e2c8d
>> Author: Larry Finger<Larry.Finger@lwfinger.net>
>> Date: Mon Sep 19 14:34:10 2011 -0500
>>
>> rtlwifi: Combine instances of RTL_HAL_IS_CCK_RATE macros.
>>
>> Three drivers, rtl8192ce, rtl8192cu and rtl8192de, use the same macro
>> to check if a particular rate is in the CCK set. This common code is
>> relocated to a common header file. A distinct macro used by rtl8192se
>> with the same name is renamed.
>>
>> Signed-off-by: Larry Finger<Larry.Finger@lwfinger.net>
>> Signed-off-by: John W. Linville<linville@tuxdriver.com>
>
> Ok, here's what I did.
>
> * merge 'master' branch of
> git://git.infradead.org/users/linville/wireless-next.git with -rc8 in
> order to get da3ba88a9996.
>
> * apply your attached patch with the Realsil facelift:
>
> patching file drivers/net/wireless/rtlwifi/rtl8192se/hw.c
> patching file drivers/net/wireless/rtlwifi/rtl8192se/reg.h
> patching file drivers/net/wireless/rtlwifi/rtl8192se/sw.c
> patching file drivers/net/wireless/rtlwifi/rtl8192se/trx.c
> Hunk #6 FAILED at 540.
> 1 out of 6 hunks FAILED -- saving rejects to file drivers/net/wireless/rtlwifi/rtl8192se/trx.c.rej
> patching file drivers/net/wireless/rtlwifi/wifi.h
> Hunk #1 succeeded at 1328 (offset 3 lines).
>
> (had to apply hunk #6 by hand though)
>
> * build
>
> drivers/net/wireless/rtlwifi/rtl8192se/sw.c:307:8: error: `EFUSE_OOB_PROTECT_BYTES_LEN' undeclared here (not in a function)
> drivers/net/wireless/rtlwifi/rtl8192se/sw.c:307:2: error: array index in initializer not of integer type
> drivers/net/wireless/rtlwifi/rtl8192se/sw.c:307:2: error: (near initialization for `rtl92se_hal_cfg.maps')
> make[5]: *** [drivers/net/wireless/rtlwifi/rtl8192se/sw.o] Error 1
> make[4]: *** [drivers/net/wireless/rtlwifi/rtl8192se] Error 2
> make[3]: *** [drivers/net/wireless/rtlwifi] Error 2
> make[2]: *** [drivers/net/wireless] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
> make: *** Waiting for unfinished jobs....
>
> fix with
>
> diff --git a/drivers/net/wireless/rtlwifi/wifi.h b/drivers/net/wireless/rtlwifi/wifi.h
> index 615f6b4..55428f2 100644
> --- a/drivers/net/wireless/rtlwifi/wifi.h
> +++ b/drivers/net/wireless/rtlwifi/wifi.h
> @@ -450,6 +450,7 @@ enum rtl_var_map {
> EFUSE_HWSET_MAX_SIZE,
> EFUSE_MAX_SECTION_MAP,
> EFUSE_REAL_CONTENT_SIZE,
> + EFUSE_OOB_PROTECT_BYTES_LEN,
>
> /*CAM map */
> RWCAM,
>
>> I have run the new version for a couple of hours without problems.
>> Perhaps it will cure your difficulty, but I am not optimistic.
>
> Yeah, I'm sorry to confirm that your pessimism turned into realism :-).
> It froze in under 20 mins. Ran the driver with default module parameters
> though.
>
> Looks like I'll have to test the Realsil tarball after all. Question, do
> I simply overwrite the subtree under drivers/net/wireless/rtlwifi/ with
> the files from the tarball?
Asa you probably do not want to kill your standard tree, unpack the Realtek
version normally, cd to where it unpacked, and do a make. Once it builds, do the
following:
sudo modprobe -rv rtl8192se
sudo modprobe -v mac80211
sudo insmod rtlwifi.ko
sudo insmod rtl8192se/rtl8192se.ko
>
> Also, any preferred module parameters settings you want me to test?
Try it first with the default parameters. If that fails, use "ips=0".
Larry
next prev parent reply other threads:[~2011-09-29 1:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 12:44 3.1-rc6+ rtl8192se issue Borislav Petkov
2011-09-15 15:23 ` Larry Finger
2011-09-15 18:41 ` Borislav Petkov
2011-09-16 18:03 ` Borislav Petkov
[not found] ` <CD4D8CF16C39438E82FE8241C9AF80F4@realsil.com.cn>
2011-09-19 9:54 ` 答复: " Borislav Petkov
2011-09-19 17:13 ` Borislav Petkov
2011-09-21 18:58 ` Borislav Petkov
[not found] ` <791179BCE62F4954AB936E6CAC9CA977@realsil.com.cn>
[not found] ` <4E7AAB8B.40900@lwfinger.net>
2011-09-22 7:51 ` 答复: " Borislav Petkov
[not found] ` <6452E68488784D0EA32E4BDF1B941EFB@realsil.com.cn>
2011-09-23 10:33 ` 答复: " Borislav Petkov
2011-09-23 13:50 ` Larry Finger
2011-09-23 16:34 ` Larry Finger
2011-09-28 13:18 ` Borislav Petkov
2011-09-29 1:57 ` Larry Finger [this message]
2011-10-05 15:15 ` Borislav Petkov
2011-10-06 2:37 ` Larry Finger
2011-11-15 13:59 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E83D092.7010405@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bp@alien8.de \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.