From: Oliver Hartkopp <socketcan@hartkopp.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, stable@kernel.org, nautsch@gmail.com
Subject: Re: [PATCH net/stable] can bcm: fix tx_setup off-by-one errors
Date: Thu, 29 Sep 2011 10:04:40 +0200 [thread overview]
Message-ID: <4E842698.8090107@hartkopp.net> (raw)
In-Reply-To: <20110929.035809.1014076114218537552.davem@davemloft.net>
On 09/29/11 09:58, David Miller wrote:
> From: Oliver Hartkopp <socketcan@hartkopp.net>
> Date: Thu, 29 Sep 2011 09:46:46 +0200
>
>> when backporting the patch to an older kernel we discovered a problem this
>> patch is introducing - which causes a new regression :-(
>>
>> Could you please revert this patch and dequeue it from stable?
>
> It's already pushed out to the net GIT tree, I can't delete history so
> now the only thing I can do is add a butt-ugly revert commit this late
> in the -rcX which is terrible.
>
> This patch was sitting out there for review for 6 days, which should
> have been more than enough time to audit it for problems.
Yeah, i'm really sorry about that.
As Linus didn't pull the latest changes, what would be your favorite then to
not revert the patch?
Sending a new fix that fixes the broken fix?
Regards,
Oliver
next prev parent reply other threads:[~2011-09-29 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 18:23 [PATCH net/stable] can bcm: fix tx_setup off-by-one errors Oliver Hartkopp
2011-09-27 21:09 ` Andre Naujoks
2011-09-29 4:33 ` David Miller
2011-09-29 7:46 ` Oliver Hartkopp
2011-09-29 7:58 ` David Miller
2011-09-29 8:04 ` Oliver Hartkopp [this message]
2011-09-29 8:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E842698.8090107@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=nautsch@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.