From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36680)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1R9G5W-0001gq-8A
	for qemu-devel@nongnu.org; Thu, 29 Sep 2011 08:51:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1R9G5Q-00081n-N8
	for qemu-devel@nongnu.org; Thu, 29 Sep 2011 08:51:42 -0400
Received: from e33.co.us.ibm.com ([32.97.110.151]:45507)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1R9G5Q-00081f-FL
	for qemu-devel@nongnu.org; Thu, 29 Sep 2011 08:51:36 -0400
Received: from /spool/local by us.ibm.com with XMail ESMTP
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Thu, 29 Sep 2011 06:51:34 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p8TCoNVQ165310
	for <qemu-devel@nongnu.org>; Thu, 29 Sep 2011 06:50:26 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p8TCoNSg015800
	for <qemu-devel@nongnu.org>; Thu, 29 Sep 2011 06:50:23 -0600
Message-ID: <4E84698B.4070602@us.ibm.com>
Date: Thu, 29 Sep 2011 07:50:19 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1317221085-5825-1-git-send-email-lcapitulino@redhat.com>
	<1317221085-5825-8-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1317221085-5825-8-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/21] qapi: generate qapi_free_* functions
 for *List types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On 09/28/2011 09:44 AM, Luiz Capitulino wrote:
> From: Michael Roth<mdroth@linux.vnet.ibm.com>
>
> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>   scripts/qapi-types.py |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
> index fc0f7af..4797a70 100644
> --- a/scripts/qapi-types.py
> +++ b/scripts/qapi-types.py
> @@ -254,6 +254,8 @@ for expr in exprs:
>       ret = "\n"
>       if expr.has_key('type'):
>           ret += generate_struct(expr['type'], "", expr['data']) + "\n"
> +        ret += generate_type_cleanup_decl(expr['type'] + "List")
> +        fdef.write(generate_type_cleanup(expr['type'] + "List") + "\n")
>           ret += generate_type_cleanup_decl(expr['type'])
>           fdef.write(generate_type_cleanup(expr['type']) + "\n")
>       elif expr.has_key('union'):