From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9GAA-0005h8-9K for qemu-devel@nongnu.org; Thu, 29 Sep 2011 08:56:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9GA4-0000cW-Fl for qemu-devel@nongnu.org; Thu, 29 Sep 2011 08:56:30 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:48261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9GA4-0000cG-DB for qemu-devel@nongnu.org; Thu, 29 Sep 2011 08:56:24 -0400 Received: from /spool/local by us.ibm.com with XMail ESMTP for from ; Thu, 29 Sep 2011 08:55:55 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8TCte9w3129456 for ; Thu, 29 Sep 2011 08:55:40 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8TCtcFI021848 for ; Thu, 29 Sep 2011 08:55:38 -0400 Message-ID: <4E846AC9.7010801@us.ibm.com> Date: Thu, 29 Sep 2011 07:55:37 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1317221085-5825-1-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1317221085-5825-1-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 00/21]: First round of QAPI conversions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On 09/28/2011 09:44 AM, Luiz Capitulino wrote: > This series is a bundle of three things: > > 1. Patches 01 to 04 add the middle mode feature to the current QMP server. > That mode allows for the current server to support QAPI commands. The > Original author is Anthony, you can find his original post here: > > http://lists.gnu.org/archive/html/qemu-devel/2011-09/msg00374.html > > 2. Patches 05 to 10 are fixes from Anthony and Michael to the QAPI > handling of the list type. > > 3. Patches 11 to 21 are simple monitor commands conversions to the QAPI. > This is just a rebase of a previous conversion work by Anthony. Great series! Other than the one minor comment re: strdup and commit messages, I think it's ready to go. Regards, Anthony Liguori > > Makefile | 12 ++ > Makefile.objs | 3 + > Makefile.target | 6 +- > error.c | 4 + > hmp-commands.hx | 11 +- > hmp.c | 116 ++++++++++++++++++ > hmp.h | 31 +++++ > monitor.c | 273 +++++-------------------------------------- > qapi-schema.json | 273 +++++++++++++++++++++++++++++++++++++++++++ > qapi/qapi-dealloc-visitor.c | 34 +++++- > qapi/qapi-types-core.h | 3 + > qapi/qmp-input-visitor.c | 4 +- > qapi/qmp-output-visitor.c | 20 +++- > qemu-char.c | 35 ++---- > qerror.c | 33 +++++ > qerror.h | 2 + > qmp-commands.hx | 57 +++++++-- > qmp.c | 92 +++++++++++++++ > scripts/qapi-commands.py | 98 ++++++++++++--- > scripts/qapi-types.py | 5 + > scripts/qapi-visit.py | 4 +- > scripts/qapi.py | 4 +- > test-qmp-commands.c | 29 +++++ > test-visitor.c | 48 +++++++-- > vl.c | 12 ++ > 25 files changed, 877 insertions(+), 332 deletions(-) > >