From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9KoA-0006I7-3y for qemu-devel@nongnu.org; Thu, 29 Sep 2011 13:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9Ko8-0000io-1q for qemu-devel@nongnu.org; Thu, 29 Sep 2011 13:54:06 -0400 Received: from david.siemens.de ([192.35.17.14]:20039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9Ko7-0000iD-Mf for qemu-devel@nongnu.org; Thu, 29 Sep 2011 13:54:04 -0400 Message-ID: <4E84B0AB.1060303@siemens.com> Date: Thu, 29 Sep 2011 19:53:47 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1ab74cea060d776b19857c3babc64d729bbdba5c.1312370658.git.jan.kiszka@siemens.com> <20110929160646.GA16909@amit-x200.redhat.com> <4E84ADCD.8030005@siemens.com> <20110929175037.GA21901@amit-x200.redhat.com> In-Reply-To: <20110929175037.GA21901@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] Delayed IP packets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Anthony Liguori , qemu-devel , Fabien Chouteau On 2011-09-29 19:50, Amit Shah wrote: > On (Thu) 29 Sep 2011 [19:41:33], Jan Kiszka wrote: >> On 2011-09-29 18:06, Amit Shah wrote: >>> On (Wed) 03 Aug 2011 [13:24:22], Jan Kiszka wrote: >>>> From: Fabien Chouteau >>>> >>>> In the current implementation, if Slirp tries to send an IP packet to a client >>>> with an unknown hardware address, the packet is simply dropped and an ARP >>>> request is sent (if_encap in slirp/slirp.c). >>>> >>>> With this patch, Slirp will send the ARP request, re-queue the packet and try >>>> to send it later. The packet is dropped after one second if the ARP reply is >>>> not received. >>> >>> This patch causes a segfault when guests wake up from hibernate. >>> >>> Recipe: >>> 1. Start guest with -net user -net nic,model=virtio >>> 2. (guest) ping 10.0.2.2 >>> 3. (guest) echo "disk" > /sys/power/state >>> 4. Re-start guest with same command line >>> 5. Ping has stopped receiving replies. >>> 6. Kill that ping process and start a new one. qemu segfaults. >> >> Can't reproduce, I'm not getting stable hibernation here even without >> any network configured. > > With virtio devices and the patches applied? Can you tell me what > you're seeing? No, I didn't patch my guest. I was using standard IDE with an emulated NIC (or without) against a 3.1-rc3 (or so) guest. > >> Could you check if the recent pull request [1] changes the picture for you? > > Thanks, that series fixes the problem. Perfect! Right in time. :) Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux