From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Jiri Olsa <jolsa@redhat.com>,
a.p.zijlstra@chello.nl, mingo@elte.hu, paulus@samba.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Exit recording if events have non matching sample type
Date: Thu, 29 Sep 2011 17:33:42 -0600 [thread overview]
Message-ID: <4E850056.1090101@gmail.com> (raw)
In-Reply-To: <20110929230613.GA20083@ghostprotocols.net>
On 09/29/2011 05:06 PM, Arnaldo Carvalho de Melo wrote:
>> >From what I can see sample_type has to be the same for all samples:
>> https://lkml.org/lkml/2011/8/15/6
>
> We could add a PERF_SAMPLE_ID2 that if present would be guaranteed to be
> the last, or we can, as PeterZ prefers/suggests, to use one mmap per
> sample id, then we know that if we're getting it on that mmap, it has
> that sample_type.
>
> For record that means we need to dump each per-sample_id mmap onto a
> separate file, i.e. use a directory, etc.
That seems like a major re-write of perf. Why not keep the existing
restriction and have users who want different sample_types run multiple
perf commands?
What's to be gained by refactoring the code to support multiple
sample_types in a single command invocation?
David
next prev parent reply other threads:[~2011-09-29 23:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 23:06 [PATCH] perf tools: Exit recording if events have non matching sample type Arnaldo Carvalho de Melo
2011-09-29 23:33 ` David Ahern [this message]
2011-09-30 0:40 ` Arnaldo Carvalho de Melo
2011-09-30 0:58 ` David Ahern
2011-09-30 2:21 ` Arnaldo Carvalho de Melo
2011-09-30 2:41 ` David Ahern
2011-09-30 7:39 ` Peter Zijlstra
2011-10-04 4:14 ` David Ahern
2011-10-04 10:00 ` Peter Zijlstra
2011-10-04 13:41 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2011-09-29 16:01 Jiri Olsa
2011-09-29 22:05 ` Arnaldo Carvalho de Melo
2011-09-29 22:55 ` David Ahern
2011-10-03 10:22 ` Jiri Olsa
2011-10-03 16:27 ` Arnaldo Carvalho de Melo
2011-10-03 19:15 ` Jiri Olsa
2011-10-17 12:50 ` Jiri Olsa
2011-10-21 7:18 ` Xu, Anhua
2011-10-21 8:10 ` Jiri Olsa
2011-10-21 14:16 ` David Ahern
2011-10-21 14:29 ` David Ahern
2011-10-21 14:43 ` Jiri Olsa
2011-10-21 14:42 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E850056.1090101@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.