All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Avoiding nographic_timer exits
Date: Fri, 30 Sep 2011 10:55:16 +0200	[thread overview]
Message-ID: <4E8583F4.6040102@siemens.com> (raw)
In-Reply-To: <4E8581F7.2070300@siemens.com>

On 2011-09-30 10:46, Jan Kiszka wrote:
> On 2011-09-30 10:18, David Gibson wrote:
>> With PowerKVM, exits from KVM to qemu are even more expensive than on
>> x86.  One significant source of these we're finding (since we usually
>> work in -nographic mode) is the nographic_timer.
>>
>> At present, we're using a hack to disable it, but that's obviously not
>> a long term solution.  From examination, it looks like the only
>> purpose of this timer is to flush coalesced mmios.  So it seems like
>> the timer should only be activated when a coalesced mmio region
>> actually exists, but I'm not entirely sure how to go about that.
>>
>> Thinking longer term, it seems very odd that a userspace periodic
>> timer handles this at all.  Surely it would make more sense to use a
>> kernel timer within KVM, which can be activated only when there are
>> actually pending coalesced MMIOs in the buffer.
> 
> Coalesced MMIO should only be flushed when a device depending on it gets
> accessed - either by a VCPU or by the iothread (to update the graphic
> output e.g.). We are working on such a concept (to reduce latency for
> VCPUs with real-time constraints).

The MMIO flush in nographic_update dates back to 62a2744ca0. Mmh, I do
understand the need for flushing with active graphic, but I do not see
the need without such output.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2011-09-30  8:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30  8:18 [Qemu-devel] Avoiding nographic_timer exits David Gibson
2011-09-30  8:46 ` Jan Kiszka
2011-09-30  8:55   ` Jan Kiszka [this message]
2011-09-30  9:18     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8583F4.6040102@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.