From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Friesen Subject: [BUG] need to export variables in config.mak Date: Fri, 30 Sep 2011 11:07:13 -0600 Message-ID: <4E85F741.2050100@genband.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org, qemu-devel@nongnu.org, Avi Kivity , Jan Kiszka Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org We've been playing a bit with kvm-kmod-3.0b. We use a cross compile environment, and one of my coworkers noticed that the variables in config.mak weren't actually exported and so didn't actually have any effect. I think something like the following patch is required. Thanks, Chris Friesen Index: kvm-kmod-3.0b/configure =================================================================== --- kvm-kmod-3.0b.orig/configure 2011-09-27 15:12:08.000009000 -0500 +++ kvm-kmod-3.0b/configure 2011-09-27 15:11:59.001566000 -0500 @@ -168,24 +168,24 @@ fi rm -f include/asm include-compat/asm mkdir -p include ln -sf asm-"$karch" include/asm ln -sf asm-"$karch" include-compat/asm cat < config.mak -ARCH=$arch -PROCESSOR=$processor -PREFIX=$prefix -KERNELDIR=$kerneldir -KERNELSOURCEDIR=$kernelsourcedir -KERNELVERSION=$kernel_version_str -CROSS_COMPILE=$cross_prefix -CC=$cross_prefix$cc -LD=$cross_prefix$ld -OBJCOPY=$cross_prefix$objcopy -AR=$cross_prefix$ar -KVM_VERSION=$(kvm_version) +export ARCH=$arch +export PROCESSOR=$processor +export PREFIX=$prefix +export KERNELDIR=$kerneldir +export KERNELSOURCEDIR=$kernelsourcedir +export KERNELVERSION=$kernel_version_str +export CROSS_COMPILE=$cross_prefix +export CC=$cross_prefix$cc +export LD=$cross_prefix$ld +export OBJCOPY=$cross_prefix$objcopy +export AR=$cross_prefix$ar +export KVM_VERSION=$(kvm_version) EOF cat < kvm-kmod-config.h #define KERNEL_EXTRAVERSION $kernel_extraversion $config_fedora_kernel EOF -- Chris Friesen Software Developer GENBAND chris.friesen@genband.com www.genband.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9gax-0008IO-64 for qemu-devel@nongnu.org; Fri, 30 Sep 2011 13:09:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9gav-00065H-Lp for qemu-devel@nongnu.org; Fri, 30 Sep 2011 13:09:55 -0400 Received: from exprod7og112.obsmtp.com ([64.18.2.177]:55840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9gav-00061I-ER for qemu-devel@nongnu.org; Fri, 30 Sep 2011 13:09:53 -0400 Message-ID: <4E85F741.2050100@genband.com> Date: Fri, 30 Sep 2011 11:07:13 -0600 From: Chris Friesen MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [BUG] need to export variables in config.mak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kvm@vger.kernel.org, qemu-devel@nongnu.org, Avi Kivity , Jan Kiszka We've been playing a bit with kvm-kmod-3.0b. We use a cross compile environment, and one of my coworkers noticed that the variables in config.mak weren't actually exported and so didn't actually have any effect. I think something like the following patch is required. Thanks, Chris Friesen Index: kvm-kmod-3.0b/configure =================================================================== --- kvm-kmod-3.0b.orig/configure 2011-09-27 15:12:08.000009000 -0500 +++ kvm-kmod-3.0b/configure 2011-09-27 15:11:59.001566000 -0500 @@ -168,24 +168,24 @@ fi rm -f include/asm include-compat/asm mkdir -p include ln -sf asm-"$karch" include/asm ln -sf asm-"$karch" include-compat/asm cat < config.mak -ARCH=$arch -PROCESSOR=$processor -PREFIX=$prefix -KERNELDIR=$kerneldir -KERNELSOURCEDIR=$kernelsourcedir -KERNELVERSION=$kernel_version_str -CROSS_COMPILE=$cross_prefix -CC=$cross_prefix$cc -LD=$cross_prefix$ld -OBJCOPY=$cross_prefix$objcopy -AR=$cross_prefix$ar -KVM_VERSION=$(kvm_version) +export ARCH=$arch +export PROCESSOR=$processor +export PREFIX=$prefix +export KERNELDIR=$kerneldir +export KERNELSOURCEDIR=$kernelsourcedir +export KERNELVERSION=$kernel_version_str +export CROSS_COMPILE=$cross_prefix +export CC=$cross_prefix$cc +export LD=$cross_prefix$ld +export OBJCOPY=$cross_prefix$objcopy +export AR=$cross_prefix$ar +export KVM_VERSION=$(kvm_version) EOF cat < kvm-kmod-config.h #define KERNEL_EXTRAVERSION $kernel_extraversion $config_fedora_kernel EOF -- Chris Friesen Software Developer GENBAND chris.friesen@genband.com www.genband.com