All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <saul.wold@intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Martin Jansa <martin.jansa@gmail.com>
Subject: Re: [PATCH] atk: add patch to replace G_CONST_RETURN with const
Date: Fri, 30 Sep 2011 10:33:18 -0700	[thread overview]
Message-ID: <4E85FD5E.7060305@intel.com> (raw)
In-Reply-To: <1317372422-7943-1-git-send-email-Martin.Jansa@gmail.com>

On 09/30/2011 01:47 AM, Martin Jansa wrote:
> * otherwise build fails when glib is 2.30.0 or newer (and G_DISABLE_DEPRECATED is enabled - like in atk)
>
> Signed-off-by: Martin Jansa<Martin.Jansa@gmail.com>
> ---
>   .../atk/atk-1.32.0/remove.G_CONST_RETURN.patch     |  628 ++++++++++++++++++++
>   meta/recipes-support/atk/atk_1.32.0.bb             |    5 +-
>   2 files changed, 632 insertions(+), 1 deletions(-)
>   create mode 100644 meta/recipes-support/atk/atk-1.32.0/remove.G_CONST_RETURN.patch
>
> diff --git a/meta/recipes-support/atk/atk-1.32.0/remove.G_CONST_RETURN.patch b/meta/recipes-support/atk/atk-1.32.0/remove.G_CONST_RETURN.patch
> new file mode 100644
> index 0000000..0cdf041
> --- /dev/null
> +++ b/meta/recipes-support/atk/atk-1.32.0/remove.G_CONST_RETURN.patch
> @@ -0,0 +1,628 @@
> +Upstream-Status: Accepted
> +
> +Similar patch is already included in 2.0.1 and newer
> +http://ftp.gnome.org/pub/gnome/sources/atk/2.0/atk-2.0.1.news
> +

No Signed-off-by: in the patch header.

If the newer version of atk is available, why not update atk in oe-core 
to that version and not add this patch?

Is there a reason we can't update to 2.0.1 at this time?

Thanks
	Sau!



  reply	other threads:[~2011-09-30 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30  8:47 [PATCH] atk: add patch to replace G_CONST_RETURN with const Martin Jansa
2011-09-30 17:33 ` Saul Wold [this message]
2011-09-30 17:43   ` Martin Jansa
2011-09-30 18:26     ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E85FD5E.7060305@intel.com \
    --to=saul.wold@intel.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.