From: Larry Finger <Larry.Finger@lwfinger.net>
To: Ian Jeffray <ian@emobix.co.uk>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
linux-wireless@vger.kernel.org
Subject: Re: r8712u driver - on ARM
Date: Sat, 01 Oct 2011 11:01:08 -0500 [thread overview]
Message-ID: <4E873944.70104@lwfinger.net> (raw)
In-Reply-To: <201109302106.12028.chunkeey@googlemail.com>
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
Ian,
Most of the skb assignments in r8712u are aligned OK and most aligned on
512-byte boundaries, but there was one that had the minimal offset of 14 bytes.
The attached patch should fix it. Does it help?
Larry
[-- Attachment #2: r8712u_align_skb_data --]
[-- Type: text/plain, Size: 730 bytes --]
Index: wireless-testing-new/drivers/staging/rtl8712/rtl8712_recv.c
===================================================================
--- wireless-testing-new.orig/drivers/staging/rtl8712/rtl8712_recv.c
+++ wireless-testing-new/drivers/staging/rtl8712/rtl8712_recv.c
@@ -372,8 +372,8 @@ static int amsdu_to_msdu(struct _adapter
pdata += ETH_HLEN;
a_len -= ETH_HLEN;
/* Allocate new skb for releasing to upper layer */
- sub_skb = dev_alloc_skb(nSubframe_Length + 12);
- skb_reserve(sub_skb, 12);
+ sub_skb = dev_alloc_skb(nSubframe_Length + 16);
+ skb_reserve(sub_skb, 16);
data_ptr = (u8 *)skb_put(sub_skb, nSubframe_Length);
memcpy(data_ptr, pdata, nSubframe_Length);
subframes[nr_subframes++] = sub_skb;
next prev parent reply other threads:[~2011-10-01 16:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 15:36 r8712u driver - on ARM Ian Jeffray
2011-09-27 16:24 ` Larry Finger
2011-09-30 18:39 ` Ian Jeffray
2011-09-30 19:06 ` Christian Lamparter
2011-10-01 0:51 ` Larry Finger
2011-10-01 16:01 ` Larry Finger [this message]
2011-10-01 16:22 ` Christian Lamparter
2011-10-01 17:52 ` Larry Finger
2011-10-01 18:01 ` Christian Lamparter
2011-10-01 18:10 ` Ian Jeffray
2011-10-01 18:49 ` Larry Finger
2011-10-01 18:54 ` Christian Lamparter
2011-10-01 19:24 ` Larry Finger
2011-10-01 23:24 ` Ian Jeffray
2011-10-12 15:30 ` Ian Jeffray
2011-10-12 17:28 ` Larry Finger
2011-10-01 17:00 ` Ian Jeffray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E873944.70104@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chunkeey@googlemail.com \
--cc=ian@emobix.co.uk \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.