From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: Fix tsc deadline timer without irqchip_in_kernel()
Date: Sun, 02 Oct 2011 18:30:50 +0200
Message-ID: <4E8891BA.2060801@redhat.com>
References: <1317549066-10582-1-git-send-email-avi@redhat.com> <4E88911E.4060702@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
	Jinsong Liu <jinsong.liu@intel.com>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:28069 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751138Ab1JBQa7 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 2 Oct 2011 12:30:59 -0400
In-Reply-To: <4E88911E.4060702@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 10/02/2011 06:28 PM, Jan Kiszka wrote:
> >  @@ -615,9 +617,12 @@ static void update_cpuid(struct kvm_vcpu *vcpu)
> >   	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL&&
> >   		best->function == 0x1) {
> >   		best->ecx |= bit(X86_FEATURE_TSC_DEADLINE_TIMER);
> >  -		vcpu->arch.apic->lapic_timer.timer_mode_mask = (3<<  17);
> >  +		timer_mode_mask = 3<<  17;
> >   	} else
> >  -		vcpu->arch.apic->lapic_timer.timer_mode_mask = (1<<  17);
> >  +		timer_mode_mask = 1<<  17;
> >  +
> >  +	if (apic)
> >  +		apic->lapic_timer.timer_mode_mask = timer_mode_mask;
>
> Coding style... While at it, you could also fix braces for that else.
>

Too late... committed and pushed, and Marcelo holds the baton now.

-- 
error compiling committee.c: too many arguments to function