From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH] KVM: Fix tsc deadline timer without irqchip_in_kernel()
Date: Sun, 02 Oct 2011 18:33:01 +0200
Message-ID: <4E88923D.8090205@web.de>
References: <1317549066-10582-1-git-send-email-avi@redhat.com> <4E88911E.4060702@web.de> <4E8891BA.2060801@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigDFC1D0246FAAF877AF9D5B81"
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
	Jinsong Liu <jinsong.liu@intel.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fmmailgate02.web.de ([217.72.192.227]:52237 "EHLO
	fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751138Ab1JBQdE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 2 Oct 2011 12:33:04 -0400
In-Reply-To: <4E8891BA.2060801@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigDFC1D0246FAAF877AF9D5B81
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2011-10-02 18:30, Avi Kivity wrote:
> On 10/02/2011 06:28 PM, Jan Kiszka wrote:
>> >  @@ -615,9 +617,12 @@ static void update_cpuid(struct kvm_vcpu *vcpu=
)
>> >       if (boot_cpu_data.x86_vendor =3D=3D X86_VENDOR_INTEL&&
>> >           best->function =3D=3D 0x1) {
>> >           best->ecx |=3D bit(X86_FEATURE_TSC_DEADLINE_TIMER);
>> >  -        vcpu->arch.apic->lapic_timer.timer_mode_mask =3D (3<<  17)=
;
>> >  +        timer_mode_mask =3D 3<<  17;
>> >       } else
>> >  -        vcpu->arch.apic->lapic_timer.timer_mode_mask =3D (1<<  17)=
;
>> >  +        timer_mode_mask =3D 1<<  17;
>> >  +
>> >  +    if (apic)
>> >  +        apic->lapic_timer.timer_mode_mask =3D timer_mode_mask;
>>
>> Coding style... While at it, you could also fix braces for that else.
>>
>=20
> Too late... committed and pushed, and Marcelo holds the baton now.

Err, sorry, this was false alarm anyway: Its perfectly valid kernel
style - for the kernel, not qemu. :)

Jan


--------------enigDFC1D0246FAAF877AF9D5B81
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6Ikj0ACgkQitSsb3rl5xRVZgCgyHX+FTe2+eA7s+vgmzjILxbu
CZoAoOFV/PTQIBmB38x2Cmf2rY88Rdnj
=7hmG
-----END PGP SIGNATURE-----

--------------enigDFC1D0246FAAF877AF9D5B81--