From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Fix tsc deadline timer without irqchip_in_kernel() Date: Sun, 02 Oct 2011 19:01:39 +0200 Message-ID: <4E8898F3.9090200@redhat.com> References: <1317549066-10582-1-git-send-email-avi@redhat.com> <4E88911E.4060702@web.de> <4E8891BA.2060801@redhat.com> <4E88923D.8090205@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti , Jinsong Liu To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44493 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596Ab1JBRBq (ORCPT ); Sun, 2 Oct 2011 13:01:46 -0400 In-Reply-To: <4E88923D.8090205@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 10/02/2011 06:33 PM, Jan Kiszka wrote: > On 2011-10-02 18:30, Avi Kivity wrote: > > On 10/02/2011 06:28 PM, Jan Kiszka wrote: > >> > @@ -615,9 +617,12 @@ static void update_cpuid(struct kvm_vcpu *vcpu) > >> > if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL&& > >> > best->function == 0x1) { > >> > best->ecx |= bit(X86_FEATURE_TSC_DEADLINE_TIMER); > >> > - vcpu->arch.apic->lapic_timer.timer_mode_mask = (3<< 17); > >> > + timer_mode_mask = 3<< 17; > >> > } else > >> > - vcpu->arch.apic->lapic_timer.timer_mode_mask = (1<< 17); > >> > + timer_mode_mask = 1<< 17; > >> > + > >> > + if (apic) > >> > + apic->lapic_timer.timer_mode_mask = timer_mode_mask; > >> > >> Coding style... While at it, you could also fix braces for that else. > >> > > > > Too late... committed and pushed, and Marcelo holds the baton now. > > Err, sorry, this was false alarm anyway: Its perfectly valid kernel > style - for the kernel, not qemu. :) > Actually CodingStyle does recomment consistent bracing in the if { multiline } else singleline case. -- error compiling committee.c: too many arguments to function