From: Boaz Harrosh <bharrosh@panasas.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
<osd-dev@open-osd.org>, <bhalevy@panasas.com>
Subject: Re: [PATCH] exofs/super.c: local functions should be static
Date: Mon, 3 Oct 2011 11:24:30 +0200 [thread overview]
Message-ID: <4E897F4E.5010703@panasas.com> (raw)
In-Reply-To: <201109231346.51759.hartleys@visionengravers.com>
On 09/23/2011 11:46 PM, H Hartley Sweeten wrote:
> This quiets the following sparse noise:
>
> warning: symbol 'exofs_sync_fs' was not declared. Should it be static?
> warning: symbol 'exofs_free_sbi' was not declared. Should it be static?
> warning: symbol 'exofs_get_parent' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Boaz Harrosh <bharrosh@panasas.com>
> Cc: Benny Halevy <bhalevy@panasas.com>
>
Both patches are in linux-next for the next merge window
Thanks Hartley
Boaz
> ---
>
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index 9049e27..8c900d4 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -356,7 +356,7 @@ static const struct export_operations exofs_export_ops;
> /*
> * Write the superblock to the OSD
> */
> -int exofs_sync_fs(struct super_block *sb, int wait)
> +static int exofs_sync_fs(struct super_block *sb, int wait)
> {
> struct exofs_sb_info *sbi;
> struct exofs_fscb *fscb;
> @@ -430,7 +430,7 @@ static void _exofs_print_device(const char *msg, const char *dev_path,
> msg, dev_path ?: "", odi->osdname, _LLU(pid));
> }
>
> -void exofs_free_sbi(struct exofs_sb_info *sbi)
> +static void exofs_free_sbi(struct exofs_sb_info *sbi)
> {
> while (sbi->comps.numdevs) {
> int i = --sbi->comps.numdevs;
> @@ -969,7 +969,7 @@ static const struct super_operations exofs_sops = {
> * EXPORT OPERATIONS
> *****************************************************************************/
>
> -struct dentry *exofs_get_parent(struct dentry *child)
> +static struct dentry *exofs_get_parent(struct dentry *child)
> {
> unsigned long ino = exofs_parent_ino(child);
>
prev parent reply other threads:[~2011-10-03 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 20:46 [PATCH] exofs/super.c: local functions should be static H Hartley Sweeten
2011-10-03 9:24 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E897F4E.5010703@panasas.com \
--to=bharrosh@panasas.com \
--cc=bhalevy@panasas.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.