From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed
Date: Mon, 03 Oct 2011 15:03:30 +0530 [thread overview]
Message-ID: <4E89816A.5050704@ti.com> (raw)
In-Reply-To: <5173921.eT2vCfT35d@wuerfel>
On Monday 03 October 2011 02:45 PM, Arnd Bergmann wrote:
> On Monday 03 October 2011 11:09:33 Santosh Shilimkar wrote:
>>> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
>>> index bb8f4a6..f7ef9f4 100644
>>> --- a/arch/arm/plat-omap/Kconfig
>>> +++ b/arch/arm/plat-omap/Kconfig
>>> @@ -217,6 +217,11 @@ config OMAP_PM_NOOP
>>>
>>> endchoice
>>>
>>> +config OMAP_CPU_FREQ
>>> + def_bool "y"
>>> + depends on CPU_FREQ
>>> + select CPU_FREQ_TABLE
>>> +
>>> endmenu
>> With CPUFREQ series from Kevin [1], I don't think we need this any-more.
>
> I guess if it's needed, it should at least be moved to the new cpufreq
> location.
>
Probably you are right. CPU_FREQ_TABLE is selected today if
CPU_FREQ_STAT or CPU_FREQ_GOV_ONDEMAND is selected. Without these two
enabled, in won't be selected.
>> More so, I didn't find OMAP_CPU_FREQ is being used anywhere on mainline.
>
> Yes, OMAP_CPU_FREQ is a symbol that is intentionally unused, with the
> only purpose of selecting CPU_FREQ_TABLE if any omap platform together
> with CPU_FREQ is enabled.
>
I see. This wasn't clear to me.
> Let's drop this patch for now, if it is still needed as I think, I can
> do a patch during the 3.2 cycle for the right location.
>
Ok.
Regards
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed
Date: Mon, 03 Oct 2011 15:03:30 +0530 [thread overview]
Message-ID: <4E89816A.5050704@ti.com> (raw)
In-Reply-To: <5173921.eT2vCfT35d@wuerfel>
On Monday 03 October 2011 02:45 PM, Arnd Bergmann wrote:
> On Monday 03 October 2011 11:09:33 Santosh Shilimkar wrote:
>>> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
>>> index bb8f4a6..f7ef9f4 100644
>>> --- a/arch/arm/plat-omap/Kconfig
>>> +++ b/arch/arm/plat-omap/Kconfig
>>> @@ -217,6 +217,11 @@ config OMAP_PM_NOOP
>>>
>>> endchoice
>>>
>>> +config OMAP_CPU_FREQ
>>> + def_bool "y"
>>> + depends on CPU_FREQ
>>> + select CPU_FREQ_TABLE
>>> +
>>> endmenu
>> With CPUFREQ series from Kevin [1], I don't think we need this any-more.
>
> I guess if it's needed, it should at least be moved to the new cpufreq
> location.
>
Probably you are right. CPU_FREQ_TABLE is selected today if
CPU_FREQ_STAT or CPU_FREQ_GOV_ONDEMAND is selected. Without these two
enabled, in won't be selected.
>> More so, I didn't find OMAP_CPU_FREQ is being used anywhere on mainline.
>
> Yes, OMAP_CPU_FREQ is a symbol that is intentionally unused, with the
> only purpose of selecting CPU_FREQ_TABLE if any omap platform together
> with CPU_FREQ is enabled.
>
I see. This wasn't clear to me.
> Let's drop this patch for now, if it is still needed as I think, I can
> do a patch during the 3.2 cycle for the right location.
>
Ok.
Regards
Santosh
next prev parent reply other threads:[~2011-10-03 9:33 UTC|newest]
Thread overview: 251+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 14:45 [PATCH 00/30] ARM/omap: omap specific randconfig fixes Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 01/30] sound/omap: omap_mcpdm_remove cannot be __devexit Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 19:24 ` Mark Brown
2011-10-02 19:24 ` Mark Brown
2011-10-02 14:45 ` [PATCH 02/30] video/omap: fix dependencies Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 6:53 ` Tomi Valkeinen
2011-10-03 6:53 ` Tomi Valkeinen
2011-10-03 9:51 ` Arnd Bergmann
2011-10-03 9:51 ` Arnd Bergmann
2011-10-03 9:51 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 03/30] video/omap: fix build dependencies Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 6:59 ` Tomi Valkeinen
2011-10-03 6:59 ` Tomi Valkeinen
2011-10-03 9:51 ` Arnd Bergmann
2011-10-03 9:51 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 04/30] ARM: omap: add missing __devexit_p() annotations Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 15:56 ` Bjarne Steinsbo
2011-10-02 15:56 ` Bjarne Steinsbo
2011-10-02 15:56 ` Bjarne Steinsbo
2011-10-02 16:09 ` Russell King - ARM Linux
2011-10-02 16:09 ` Russell King - ARM Linux
2011-10-03 17:46 ` Tony Lindgren
2011-10-03 17:46 ` Tony Lindgren
2011-10-03 17:48 ` Tony Lindgren
2011-10-03 17:48 ` Tony Lindgren
2011-10-03 4:59 ` Santosh Shilimkar
2011-10-03 4:59 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 05/30] ARM: omap: enable building omap2 without omap2420/2430 Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:07 ` Santosh Shilimkar
2011-10-03 5:07 ` Santosh Shilimkar
2011-10-03 17:53 ` Tony Lindgren
2011-10-03 17:53 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 06/30] ARM: omap: fix build with CONFIG_I2C_OMAP disabled Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:06 ` Santosh Shilimkar
2011-10-03 5:06 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 07/30] ARM: omap: fix visibility of omap2_mbox_iva_priv Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:08 ` Santosh Shilimkar
2011-10-03 5:08 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 08/30] ARM: omap2+: fix building without i2c Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 1:31 ` Paul Walmsley
2011-10-03 1:31 ` Paul Walmsley
2011-10-03 1:31 ` Paul Walmsley
2011-10-03 9:49 ` Arnd Bergmann
2011-10-03 9:49 ` Arnd Bergmann
2011-10-03 9:49 ` Arnd Bergmann
2011-10-03 17:56 ` Tony Lindgren
2011-10-03 17:56 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 09/30] ARM: omap2: export functions used by nand driver Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 17:56 ` Tony Lindgren
2011-10-03 17:56 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 10/30] ARM: omap/iommu: always provide iommu debug code Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 16:34 ` Ohad Ben-Cohen
2011-10-02 16:34 ` Ohad Ben-Cohen
2011-10-02 16:34 ` Ohad Ben-Cohen
2011-10-02 18:01 ` Arnd Bergmann
2011-10-02 18:01 ` Arnd Bergmann
2011-10-02 18:21 ` Ohad Ben-Cohen
2011-10-02 18:21 ` Ohad Ben-Cohen
2011-10-03 17:57 ` Tony Lindgren
2011-10-03 17:57 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 11/30] ARM: omap2/n8x0: work around modular omap mmc Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 15:53 ` Russell King - ARM Linux
2011-10-02 15:53 ` Russell King - ARM Linux
2011-10-02 18:54 ` Arnd Bergmann
2011-10-02 18:54 ` Arnd Bergmann
2011-10-02 18:54 ` Arnd Bergmann
2011-10-03 18:03 ` Tony Lindgren
2011-10-03 18:03 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 12/30] ARM: omap4: always build omap_phy_internal Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 18:04 ` Tony Lindgren
2011-10-03 18:04 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 13/30] ARM: omap2+: fix omap_hdq_init compilation Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:11 ` Santosh Shilimkar
2011-10-03 5:11 ` Santosh Shilimkar
2011-10-03 18:06 ` Tony Lindgren
2011-10-03 18:06 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 14/30] ARM: omap2: irq.c is always needed Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:14 ` Santosh Shilimkar
2011-10-03 5:14 ` Santosh Shilimkar
2011-10-03 5:14 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 16:14 ` Russell King - ARM Linux
2011-10-02 16:14 ` Russell King - ARM Linux
2011-10-02 16:14 ` Russell King - ARM Linux
2011-10-02 18:00 ` Arnd Bergmann
2011-10-02 18:00 ` Arnd Bergmann
2011-10-02 18:00 ` Arnd Bergmann
2011-10-02 18:56 ` Felipe Balbi
2011-10-02 18:56 ` Felipe Balbi
[not found] ` <20111002185608.GA25690-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-10-02 19:44 ` Arnd Bergmann
2011-10-02 19:44 ` Arnd Bergmann
2011-10-02 19:44 ` Arnd Bergmann
2011-10-02 22:10 ` Felipe Balbi
2011-10-02 22:10 ` Felipe Balbi
2011-10-02 22:10 ` Felipe Balbi
2011-10-03 9:40 ` Arnd Bergmann
2011-10-03 9:40 ` Arnd Bergmann
2011-10-03 9:40 ` Arnd Bergmann
2011-10-03 10:07 ` Felipe Balbi
2011-10-03 10:07 ` Felipe Balbi
2011-10-03 10:07 ` Felipe Balbi
2011-10-10 6:10 ` Felipe Balbi
2011-10-10 6:10 ` Felipe Balbi
2011-10-02 14:45 ` [PATCH 16/30] usb/musb: HDRC depends on TWL4030_CORE for OMAP3/4 Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 18:59 ` Felipe Balbi
2011-10-02 18:59 ` Felipe Balbi
2011-10-02 18:59 ` Felipe Balbi
2011-10-02 14:45 ` [PATCH 17/30] usb/musb: allow building USB_MUSB_TUSB6010 as a module Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 18:14 ` Tony Lindgren
2011-10-03 18:14 ` Tony Lindgren
2011-10-10 6:10 ` Felipe Balbi
2011-10-10 6:10 ` Felipe Balbi
2011-10-02 14:45 ` [PATCH 18/30] omap-usb: automatically select MFD_OMAP_USB_HOST Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-04 11:00 ` Samuel Ortiz
2011-10-04 11:00 ` Samuel Ortiz
2011-10-02 14:45 ` [PATCH 19/30] tty/serial/omap: console can only be built-in Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 4:53 ` Govindraj
2011-10-03 4:53 ` Govindraj
2011-10-03 4:53 ` Govindraj
2011-10-02 14:45 ` [PATCH 20/30] media/omap_vout: disable driver for now Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 6:09 ` Archit Taneja
2011-10-03 6:09 ` Archit Taneja
2011-10-03 6:09 ` Archit Taneja
2011-10-03 9:16 ` Arnd Bergmann
2011-10-03 9:16 ` Arnd Bergmann
2011-10-03 9:16 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 21/30] sound/soc/omap: limit to omap2plus Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-02 17:40 ` Jarkko Nikula
2011-10-02 17:40 ` Jarkko Nikula
2011-10-02 18:03 ` Arnd Bergmann
2011-10-02 18:03 ` Arnd Bergmann
2011-10-02 18:24 ` Jarkko Nikula
2011-10-02 18:24 ` Jarkko Nikula
2011-10-02 18:24 ` Jarkko Nikula
2011-10-02 18:30 ` Arnd Bergmann
2011-10-02 18:30 ` Arnd Bergmann
2011-10-02 19:18 ` Mark Brown
2011-10-02 19:18 ` Mark Brown
2011-10-02 14:45 ` [PATCH 22/30] mfd: build twl6030 only on omap2 Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-04 10:47 ` Samuel Ortiz
2011-10-04 10:47 ` Samuel Ortiz
2011-10-04 14:47 ` Arnd Bergmann
2011-10-04 14:47 ` Arnd Bergmann
2011-10-02 14:45 ` [PATCH 23/30] ARM: omap2: select twl4030 support on boards that need it Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:19 ` Santosh Shilimkar
2011-10-03 5:19 ` Santosh Shilimkar
2011-10-03 11:03 ` Arnd Bergmann
2011-10-03 11:03 ` Arnd Bergmann
2011-10-03 18:18 ` Tony Lindgren
2011-10-03 18:18 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 24/30] ARM: omap2+: ensure that one of omap2/3/4 is selected Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:20 ` Santosh Shilimkar
2011-10-03 5:20 ` Santosh Shilimkar
2011-10-03 18:21 ` Tony Lindgren
2011-10-03 18:21 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 25/30] ARM: OMAP depends on MMU Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:21 ` Santosh Shilimkar
2011-10-03 5:21 ` Santosh Shilimkar
2011-10-03 18:22 ` Tony Lindgren
2011-10-03 18:22 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 26/30] ARM: omap: add board autoselection Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:28 ` Santosh Shilimkar
2011-10-03 5:28 ` Santosh Shilimkar
2011-10-03 9:11 ` Arnd Bergmann
2011-10-03 9:11 ` Arnd Bergmann
2011-10-03 9:11 ` Arnd Bergmann
2011-10-03 9:19 ` Santosh Shilimkar
2011-10-03 9:19 ` Santosh Shilimkar
2011-10-03 9:27 ` Cousson, Benoit
2011-10-03 9:27 ` Cousson, Benoit
2011-10-03 9:54 ` Arnd Bergmann
2011-10-03 9:54 ` Arnd Bergmann
2011-10-03 9:54 ` Arnd Bergmann
2011-10-03 18:26 ` Tony Lindgren
2011-10-03 18:26 ` Tony Lindgren
2011-10-04 7:44 ` Arnd Bergmann
2011-10-04 7:44 ` Arnd Bergmann
2011-10-04 7:44 ` Arnd Bergmann
2011-10-04 15:57 ` Tony Lindgren
2011-10-04 15:57 ` Tony Lindgren
2011-10-04 19:29 ` Arnd Bergmann
2011-10-04 19:29 ` Arnd Bergmann
2011-10-05 1:05 ` [GIT PULL] initial omap DT support for v3.2 merge window (Re: [PATCH 26/30] ARM: omap: add board autoselection) Tony Lindgren
2011-10-05 1:05 ` Tony Lindgren
2011-10-14 16:02 ` Tony Lindgren
2011-10-14 16:02 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 27/30] ARM: omap: select L2X0 cache on omap4 Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:29 ` Santosh Shilimkar
2011-10-03 5:29 ` Santosh Shilimkar
2011-10-03 5:29 ` Santosh Shilimkar
2011-10-03 18:27 ` Tony Lindgren
2011-10-03 18:27 ` Tony Lindgren
2011-10-02 14:45 ` [PATCH 28/30] ARM: omap: select CPU_FREQ_TABLE where needed Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 5:39 ` Santosh Shilimkar
2011-10-03 5:39 ` Santosh Shilimkar
2011-10-03 5:39 ` Santosh Shilimkar
2011-10-03 9:15 ` Arnd Bergmann
2011-10-03 9:15 ` Arnd Bergmann
2011-10-03 9:15 ` Arnd Bergmann
2011-10-03 9:33 ` Santosh Shilimkar [this message]
2011-10-03 9:33 ` Santosh Shilimkar
2011-10-02 14:45 ` [PATCH 29/30] ARM: omap: select USB_ARCH_HAS_EHCI only when USB is enabled Arnd Bergmann
2011-10-02 14:45 ` Arnd Bergmann
2011-10-03 18:27 ` Tony Lindgren
2011-10-03 18:27 ` Tony Lindgren
2011-10-02 14:46 ` [PATCH 30/30] ARM: omap2: select ARM_AMBA for OMAP3_EMU Arnd Bergmann
2011-10-02 14:46 ` Arnd Bergmann
2011-10-03 5:31 ` Santosh Shilimkar
2011-10-03 5:31 ` Santosh Shilimkar
2011-10-03 18:28 ` Tony Lindgren
2011-10-03 18:28 ` Tony Lindgren
2011-10-03 5:05 ` [PATCH 00/30] ARM/omap: omap specific randconfig fixes Santosh Shilimkar
2011-10-03 5:05 ` Santosh Shilimkar
2011-10-03 9:22 ` Arnd Bergmann
2011-10-03 9:22 ` Arnd Bergmann
2011-10-03 9:42 ` Santosh Shilimkar
2011-10-03 9:42 ` Santosh Shilimkar
2011-10-03 18:29 ` Tony Lindgren
2011-10-03 18:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E89816A.5050704@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.