From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH 3/3] tty/serial: atmel_serial: __devinit_p for probe function Date: Mon, 03 Oct 2011 11:49:11 +0200 Message-ID: <4E898517.6020104@atmel.com> References: <4355360.0xR5ZY7sEk@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from newsmtp5.atmel.com ([204.2.163.5]:63182 "EHLO sjogate2.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503Ab1JCJtc (ORCPT ); Mon, 3 Oct 2011 05:49:32 -0400 In-Reply-To: <4355360.0xR5ZY7sEk@wuerfel> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, alan@linux.intel.com, linux-serial@vger.kernel.org, plagnioj@jcrosoft.com, linux-kernel@vger.kernel.org, Russell King - ARM Linux On 10/03/2011 11:36 AM, Arnd Bergmann : > On Monday 03 October 2011 12:11:19 Nicolas Ferre wrote: >> } >> >> static struct platform_driver atmel_serial_driver = { >> - .probe = atmel_serial_probe, >> + .probe = __devinit_p(atmel_serial_probe), >> .remove = __devexit_p(atmel_serial_remove), >> .suspend = atmel_serial_suspend, >> .resume = atmel_serial_resume, > > Still wrong: __devinit_p does not exist and is not needed. OMG, the not-enouth-coffee syndrome... twice! So we forget all this and I try to increase my signal/noise ratio ;-) Bye, -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Mon, 03 Oct 2011 11:49:11 +0200 Subject: [PATCH 3/3] tty/serial: atmel_serial: __devinit_p for probe function In-Reply-To: <4355360.0xR5ZY7sEk@wuerfel> References: <4355360.0xR5ZY7sEk@wuerfel> Message-ID: <4E898517.6020104@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/03/2011 11:36 AM, Arnd Bergmann : > On Monday 03 October 2011 12:11:19 Nicolas Ferre wrote: >> } >> >> static struct platform_driver atmel_serial_driver = { >> - .probe = atmel_serial_probe, >> + .probe = __devinit_p(atmel_serial_probe), >> .remove = __devexit_p(atmel_serial_remove), >> .suspend = atmel_serial_suspend, >> .resume = atmel_serial_resume, > > Still wrong: __devinit_p does not exist and is not needed. OMG, the not-enouth-coffee syndrome... twice! So we forget all this and I try to increase my signal/noise ratio ;-) Bye, -- Nicolas Ferre