From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: netdev@vger.kernel.org
Subject: [iproute2 PATCH 08/11] Fix file descriptor leak on error in read_viftable()
Date: Mon, 03 Oct 2011 17:24:08 +0200 [thread overview]
Message-ID: <4E89D398.50703@intra2net.com> (raw)
Detected by cppcheck.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
ip/ipmroute.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/ip/ipmroute.c b/ip/ipmroute.c
index a4389f5..f033349 100644
--- a/ip/ipmroute.c
+++ b/ip/ipmroute.c
@@ -58,9 +58,10 @@ static void read_viftable(void)
if (!fp)
return;
- if (!fgets(buf, sizeof(buf), fp))
+ if (!fgets(buf, sizeof(buf), fp)) {
+ fclose(fp);
return;
-
+ }
while (fgets(buf, sizeof(buf), fp)) {
int vifi;
char dev[256];
--
1.7.4.4
reply other threads:[~2011-10-03 15:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E89D398.50703@intra2net.com \
--to=thomas.jarosch@intra2net.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.