From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH] e2fsprogs: use ALL_CFLAGS to build gen_crc32ctable
Date: Mon, 03 Oct 2011 11:14:15 -0500 [thread overview]
Message-ID: <4E89DF57.90806@redhat.com> (raw)
With just BUILD_CFLAGS this we don't get the right include
paths (i.e. within the tree) to build the gen_crc32ctable binary.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
I think that the rule could probably be removed altogether, and
gen_crc32ctable.o would be built from gen_crc32ctable.c, and
the normal dependencies & rules would build gen_crc32ctable.
But this seems like the most obvious change.
diff --git a/lib/ext2fs/Makefile.in b/lib/ext2fs/Makefile.in
index 3de9f87..07a0db18 100644
--- a/lib/ext2fs/Makefile.in
+++ b/lib/ext2fs/Makefile.in
@@ -413,7 +413,7 @@ $(OBJS): subdirs
gen_crc32ctable: $(srcdir)/gen_crc32ctable.c
$(E) " CC $@"
- $(Q) $(BUILD_CC) $(BUILD_CFLAGS) -o gen_crc32ctable \
+ $(Q) $(BUILD_CC) $(ALL_CFLAGS) -o gen_crc32ctable \
$(srcdir)/gen_crc32ctable.c
crc32c_table.h: gen_crc32ctable
next reply other threads:[~2011-10-03 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 16:14 Eric Sandeen [this message]
2011-10-04 3:02 ` e2fsprogs: use ALL_CFLAGS to build gen_crc32ctable Ted Ts'o
2011-10-10 17:39 ` Eric Sandeen
2011-10-10 17:52 ` Eric Sandeen
2011-10-10 18:42 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E89DF57.90806@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.