From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] GCC4,6: Squash warning in cmd_nand.c
Date: Mon, 3 Oct 2011 11:22:21 -0500 [thread overview]
Message-ID: <4E89E13D.2080006@freescale.com> (raw)
In-Reply-To: <201109301214.46070.marek.vasut@gmail.com>
On 09/30/2011 05:14 AM, Marek Vasut wrote:
> On Friday, September 30, 2011 12:13:23 PM Marek Vasut wrote:
>> cmd_nand.c: In function ?do_nand?:
>> cmd_nand.c:490:7: warning: variable ?chip? set but not used
>> [-Wunused-but-set-variable]
>> cmd_nand.c:489:7: warning: variable ?part? set but not used
>> [-Wunused-but-set-variable]
>>
>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>> Cc: Scott Wood <scottwood@freescale.com>
>> ---
>> common/cmd_nand.c | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>
> This even looks like .part and .chip has no effect at all ... am I right ?
They affect error checking. Beyond that, the code can tell what to do
from the number of arguments. The idea was that accidentally leaving
out an argument (such as by a misspelled $varaible) shouldn't end up
erasing more than you expected.
-Scott
next prev parent reply other threads:[~2011-10-03 16:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 10:13 [U-Boot] [PATCH 1/5] GCC4.6: Squash warning in nand_bbt.c Marek Vasut
2011-09-30 10:13 ` [U-Boot] [PATCH 2/5] GCC4,6: Squash warning in cmd_nand.c Marek Vasut
2011-09-30 10:14 ` Marek Vasut
2011-10-03 16:22 ` Scott Wood [this message]
2011-09-30 15:57 ` Mike Frysinger
2011-10-01 21:31 ` Wolfgang Denk
2011-09-30 10:13 ` [U-Boot] [PATCH 3/5] GCC4.6: Squash warning in vmt.c Marek Vasut
2011-09-30 10:19 ` [U-Boot] [PATCH 3/5 V2] " Marek Vasut
2011-09-30 15:57 ` Mike Frysinger
2011-09-30 15:57 ` [U-Boot] [PATCH 3/5] " Mike Frysinger
2011-09-30 10:13 ` [U-Boot] [PATCH 4/5] GCC4.6: Squash warning in cmd_ubi.c: Marek Vasut
2011-09-30 15:54 ` Mike Frysinger
2011-09-30 10:13 ` [U-Boot] [PATCH 5/5] GCC4.6: Squash warning in lzo1x_decompress.c Marek Vasut
2011-09-30 15:56 ` Mike Frysinger
2011-09-30 15:57 ` [U-Boot] [PATCH 1/5] GCC4.6: Squash warning in nand_bbt.c Mike Frysinger
2011-10-01 21:28 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E89E13D.2080006@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.