From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] [SCSI] remove arbitrary SD_MAX_DISKS namespace limit
Date: Mon, 03 Oct 2011 11:47:29 -0500 [thread overview]
Message-ID: <4E89E721.7000308@oracle.com> (raw)
I see no reason to limit the SCSI disk namespace to sdXXX. We test
systems with more than 18278 LUNs.
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 953773c..741c7f7 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2592,12 +2592,6 @@ static int sd_probe(struct device *dev)
if (error)
goto out_put;
- if (index >= SD_MAX_DISKS) {
- error = -ENODEV;
- sdev_printk(KERN_WARNING, sdp, "SCSI disk (sd) name space exhausted.\n");
- goto out_free_index;
- }
-
error = sd_format_disk_name("sd", index, gd->disk_name, DISK_NAME_LEN);
if (error)
goto out_free_index;
diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
index 6ad798b..4163f29 100644
--- a/drivers/scsi/sd.h
+++ b/drivers/scsi/sd.h
@@ -9,12 +9,6 @@
#define SD_MAJORS 16
/*
- * This is limited by the naming scheme enforced in sd_probe,
- * add another character to it if you really need more disks.
- */
-#define SD_MAX_DISKS (((26 * 26) + 26 + 1) * 26)
-
-/*
* Time out in seconds for disks and Magneto-opticals (which are slower).
*/
#define SD_TIMEOUT (30 * HZ)
next reply other threads:[~2011-10-03 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 16:47 Dave Kleikamp [this message]
2011-10-03 17:57 ` [PATCH] [SCSI] remove arbitrary SD_MAX_DISKS namespace limit James Bottomley
2011-10-03 18:29 ` Dave Kleikamp
2011-10-19 16:49 ` [PATCH v2] " Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E89E721.7000308@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.