All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: vikas.chaudhary@qlogic.com
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
	lalit.chandivade@qlogic.com, ravi.anand@qlogic.com
Subject: Re: [PATCH 05/13] qla4xxx: Fix exporting boot targets to sysfs
Date: Mon, 03 Oct 2011 15:46:56 -0500	[thread overview]
Message-ID: <4E8A1F40.2030208@cs.wisc.edu> (raw)
In-Reply-To: <1317662967-30110-6-git-send-email-vikas.chaudhary@qlogic.com>

On 10/03/2011 12:29 PM, vikas.chaudhary@qlogic.com wrote:
> From: Lalit Chandivade <lalit.chandivade@qlogic.com>
> 
> The driver failed to export primary boot target if secondary target did not
> exist in the FLASH. If boot targets are not valid then driver assumed 0 and
> 1 as default boot targets. Since these target did not exist in flash, the
> driver failed exporting all the targets.
> Also fixed,
> - for 8022 calculate max chap entries based on the size of CHAP table in FLASH
> - If a boot target has a BIDI CHAP enabled, then read the user/secret from
> CHAP table. Do not assume BIDI chap at peer CHAP idx + 1

You would normally want to send that in another patch.


> +/**
> + * qla4xxx_get_bidi_chap - Get a BI-DI CHAP user and secret.
> + * @ha: pointer to adapter structure
> + * @username
> + * @password
> + *

Forgot to add a description again.

You can probably just ask James if it would be ok to send a patch to fix
them all up over this patchset so you do not have to resend patches.

  reply	other threads:[~2011-10-03 20:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-03 17:29 [PATCH 00/13] qla4xxx: Patches for scsi-misc vikas.chaudhary
2011-10-03 17:29 ` [PATCH 01/13] qla4xxx: Add new FLT firmware region vikas.chaudhary
2011-10-03 17:29 ` [PATCH 02/13] qla4xxx: Update license vikas.chaudhary
2011-10-03 17:29 ` [PATCH 03/13] qla4xxx: Fix bidirectional CHAP vikas.chaudhary
2011-10-03 17:29 ` [PATCH 04/13] qla4xxx: Do not add duplicate CHAP entry in FLASH vikas.chaudhary
2011-10-03 20:40   ` Mike Christie
2011-10-03 20:41     ` Mike Christie
2011-10-04 17:13       ` Vikas Chaudhary
2011-10-03 17:29 ` [PATCH 05/13] qla4xxx: Fix exporting boot targets to sysfs vikas.chaudhary
2011-10-03 20:46   ` Mike Christie [this message]
2011-10-03 20:44     ` James Bottomley
2011-10-03 17:29 ` [PATCH 06/13] qla4xxx: Free Device Database (DDB) reserved by FW vikas.chaudhary
2011-10-03 17:29 ` [PATCH 07/13] qla4xxx: Clear DDB map index on the basis of AEN vikas.chaudhary
2011-10-03 17:29 ` [PATCH 08/13] qla4xxx: Fixed session destroy issue on link up-down vikas.chaudhary
2011-10-03 17:29 ` [PATCH 09/13] qla4xxx: Fixed device blocked " vikas.chaudhary
2011-10-03 21:01   ` Mike Christie
2011-10-03 21:16     ` Mike Christie
2011-10-04 17:07       ` Vikas Chaudhary
2011-10-03 17:29 ` [PATCH 10/13] qla4xxx: Fixed active session re-open issue vikas.chaudhary
2011-10-03 17:29 ` [PATCH 11/13] qla4xxx: Fixed target discovery failed issue vikas.chaudhary
2011-10-03 17:29 ` [PATCH 12/13] qla4xxx: updated device id check for BFS vikas.chaudhary
2011-10-03 17:29 ` [PATCH 13/13] qla4xxx: Update driver version to 5.02.00-k8 vikas.chaudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8A1F40.2030208@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=jbottomley@parallels.com \
    --cc=lalit.chandivade@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ravi.anand@qlogic.com \
    --cc=vikas.chaudhary@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.