From: Ryan Mallon <rmallon@gmail.com>
To: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] Staging: comedi: fix printk issue in cb_pcidio.c
Date: Tue, 04 Oct 2011 10:27:41 +1100 [thread overview]
Message-ID: <4E8A44ED.4090406@gmail.com> (raw)
In-Reply-To: <1317388707-1980-1-git-send-email-ravishankar.km@greenturtles.in>
On 30/09/11 23:18, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the cb_pcidio.c file that fixes up a printk warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
> ---
> drivers/staging/comedi/drivers/cb_pcidio.c | 27 +++++++++++++++------------
> 1 files changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidio.c b/drivers/staging/comedi/drivers/cb_pcidio.c
> index 79477a5..85cc78d 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidio.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidio.c
> @@ -184,7 +184,8 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> int index;
> int i;
>
> - printk("comedi%d: cb_pcidio: \n", dev->minor);
> + dev_info(&pcidev->dev, "comedi%d: cb_pcidio:\n",
> + dev->minor);
>
> /*
> * Allocate the private structure area. alloc_private() is a
> @@ -223,8 +224,9 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> }
> }
>
> - printk("No supported ComputerBoards/MeasurementComputing card found on "
> - "requested position\n");
> + dev_err(&pcidev->dev, "No supported"
> + " ComputerBoards/MeasurementComputing"
> + " card found on requested position\n");
printk strings should be on a single line (80 column rule doesn't apply)
so that they can be easily grepped for. There are many instances which
need to be fixed in this series.
~Ryan
prev parent reply other threads:[~2011-10-03 23:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 13:18 [PATCH 1/9] Staging: comedi: fix printk issue in cb_pcidio.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 2/9] Staging: comedi: fix printk issue in cb_pcidda.c Ravishankar Karkala Mallikarjunayya
2011-10-01 15:05 ` Dan Carpenter
2011-09-30 13:18 ` [PATCH 3/9] Staging: comedi: fix printk issue in cb_pcidas.c Ravishankar Karkala Mallikarjunayya
2011-10-01 15:09 ` Dan Carpenter
2011-10-03 23:30 ` Ryan Mallon
2011-10-04 0:57 ` Joe Perches
2011-09-30 13:18 ` [PATCH 4/9] Staging: comedi: fix printk issue in cb_pcidas64.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 5/9] Staging: comedi: fix printk issue in cb_pcimdas.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 6/9] Staging: comedi: fix line over 80 character issue in cb_pcidio.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 7/9] Staging: comedi: fix line over 80 character issue in cb_pcidda.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 8/9] Staging: comedi: fix printk issue in cb_pcidas.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 9/9] Staging: comedi: fix line over 80 character " Ravishankar Karkala Mallikarjunayya
2011-10-03 23:27 ` Ryan Mallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8A44ED.4090406@gmail.com \
--to=rmallon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankar.km@greenturtles.in \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.