From: Daniele Nicolodi <daniele@domain.hid>
To: Alexis Berlemont <alexis.berlemont@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-core] Analogy: idx_write_subd field in a4l_desc_t
Date: Tue, 04 Oct 2011 09:48:47 +0200 [thread overview]
Message-ID: <4E8ABA5F.6020604@domain.hid> (raw)
In-Reply-To: <CAMesUR40qfwCK0HARML05E+1a3DwaiqZGmEJYY-Nn2pRsc4UyA@mail.gmail.com>
On 01/10/11 00:03, Alexis Berlemont wrote:
>> I'm using xenomai-head on a 2.6.38.8 kernel on x86 with a NI-6251 DAQ
>> board. In this configuration the idx_write_subd field of the a4l_desc_t
>> structure filled by a4l_open() is not set to the proper value but is set
>> to NULL.
>>
>> In previous xanomai/analogy releases this was working properly. Has some
>> initialization code been removed in the latest analogy drivers refactoring?
>
> Yes. Formerly, on both sides (kernel and user), we used some
> description fields (idx_read_subd and idx_write_subd) so as to quickly
> identify default asynchronous input and output subdevices and to link
> them with buffers (into which, input / output data are copied).
...
> For API / ABI compatibility reasons, I waited a major release before
> removing the fields idx_{read, write}_subd. I should have thought
> twice before removing their initializations. I will fix that soon,
> sorry.
Hello Alexis,
the rational of the change is clear, however having the field in the
structure, but with the wrong value is confusing, especially so because
the documentation does not mention that this field is deprecated and its
value should not be trusted.
I would remove the field altogether, or put back the initialization and
mention the deprecation in the documentation.
> I implemented this change more than one year ago (here is on of the
> many related commits 58ebd5b7efe0cc0ac1e82991d12125ce34dfeee3). That
> was already present in 2.5. Which version were you formerly using?
I thought I was using Xenomai 2.5.6.
Cheers,
--
Daniele
prev parent reply other threads:[~2011-10-04 7:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 14:06 [Xenomai-core] Analogy: idx_write_subd field in a4l_desc_t Daniele Nicolodi
2011-09-30 22:03 ` Alexis Berlemont
2011-10-01 18:07 ` Gilles Chanteperdrix
2011-10-04 7:58 ` Daniele Nicolodi
2011-10-04 11:17 ` Gilles Chanteperdrix
2011-10-04 13:31 ` Daniele Nicolodi
2011-10-05 21:53 ` Alexis Berlemont
2011-10-04 7:48 ` Daniele Nicolodi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8ABA5F.6020604@domain.hid \
--to=daniele@domain.hid \
--cc=alexis.berlemont@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.