From: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
To: ofono@ofono.org
Subject: Re: [PATCHv8 3/6] plugins: mobile-broadband-provider-info parser changes
Date: Tue, 04 Oct 2011 12:33:41 +0300 [thread overview]
Message-ID: <4E8AD2F5.50308@intel.com> (raw)
In-Reply-To: <4E85D8E9.4010302@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
Hello Denis,
On 09/30/2011 05:57 PM, Denis Kenzior wrote:
> This patch makes no logical sense. If you want to add a new
> mbpi_ap_type function, then send a patch against mbpi.h and mbpi.c
> adding such a function.
>
> If you want to rename mbpi_provision_data_free to mbpi_ap_free, then
> send a patch against mbpi.h, mbpi.c and a separate patch against
> tools/lookup-apn.c
>
> The only time you should separate .h and .c patches are when you're
> modifying public API in include/*
>
> See HACKING document, the 'Submitting patches' section in particular.
Thanks for the info, indeed splitting of patches per directory is explained
there. However, 'Submitting patches' is actually silent about the rest.
I will prepare and send another patch set.
Regards,
Oleg
--
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
next prev parent reply other threads:[~2011-10-04 9:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 13:31 [PATCHv8 0/6] Provisioning plugin Oleg Zhurakivskyy
2011-09-30 13:31 ` [PATCHv8 1/6] plugins: Provisioning plugin autoconf support Oleg Zhurakivskyy
2011-09-30 13:31 ` [PATCHv8 2/6] plugins: Provisioning plugin makefile changes Oleg Zhurakivskyy
2011-09-30 13:31 ` [PATCHv8 3/6] plugins: mobile-broadband-provider-info parser changes Oleg Zhurakivskyy
2011-09-30 14:57 ` Denis Kenzior
2011-10-04 9:33 ` Oleg Zhurakivskyy [this message]
2011-09-30 13:31 ` [PATCHv8 4/6] " Oleg Zhurakivskyy
2011-09-30 15:20 ` Denis Kenzior
2011-10-04 9:33 ` Oleg Zhurakivskyy
2011-10-04 14:05 ` Denis Kenzior
2011-10-05 8:07 ` Oleg Zhurakivskyy
2011-09-30 13:31 ` [PATCHv8 5/6] plugins: Add provisioning plugin Oleg Zhurakivskyy
2011-09-30 13:31 ` [PATCHv8 6/6] tools: lookup-apn update Oleg Zhurakivskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8AD2F5.50308@intel.com \
--to=oleg.zhurakivskyy@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.