From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Valdis.Kletnieks@vt.edu
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 2/4] [TRIVIAL] ftrace/kprobes: Fix an warning typo
Date: Wed, 05 Oct 2011 13:08:01 +0900 [thread overview]
Message-ID: <4E8BD821.1020604@hitachi.com> (raw)
In-Reply-To: <14310.1317743883@turing-police.cc.vt.edu>
(2011/10/05 0:58), Valdis.Kletnieks@vt.edu wrote:
> On Tue, 04 Oct 2011 19:44:49 +0900, Masami Hiramatsu said:
>> Add a space between words.
>
>> if (ret == -ENOENT && trace_probe_is_on_module(tp)) {
>> - pr_warning("This probe might be able to register after"
>> + pr_warning("This probe might be able to register after "
>> "target module is loaded. Continue.\n");
>
> Better would be to make it all one line. Keeping a string together trumps the
> 80-column rule.
>
Agreed :) I'd like to check whether other messages should be fixed too.
Thank you,
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2011-10-05 4:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 10:44 [PATCH 1/4] [BUGFIX] ftrace/kprobes: Fix not to delete probes if in use Masami Hiramatsu
2011-10-04 10:44 ` [PATCH 2/4] [TRIVIAL] ftrace/kprobes: Fix an warning typo Masami Hiramatsu
2011-10-04 15:58 ` Valdis.Kletnieks
2011-10-05 4:08 ` Masami Hiramatsu [this message]
2011-10-04 10:44 ` [PATCH 3/4] [TRIVIAL] perftools: Fix a typo of command name as trace-cmd Masami Hiramatsu
2011-10-04 10:45 ` [PATCH 4/4] [BUGFIX] perf probe: Fix to show correct error string Masami Hiramatsu
2011-10-08 5:00 ` [PATCH 1/4] [BUGFIX] ftrace/kprobes: Fix not to delete probes if in use Steven Rostedt
2011-10-10 14:14 ` Masami Hiramatsu
2011-10-10 19:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8BD821.1020604@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.