build failure caused by $(XEN_ROOT)/.config

build failure caused by $(XEN_ROOT)/.config

[Kay, Allen M]

[-- Attachment #1.1: Type: text/plain, Size: 779 bytes --]

Hi Keir,

I'm getting the following build error caused by "-include $(XEN_ROOT)/.config" line in Config.mk.  Removing it from Config.mk makes the error go away.  The OS I'm using is FC15.  "$(XEN_ROOT)/.config" does not exist.

Allen

-------

make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[4]: *** ../../.config: Is a directory.  Stop.
make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[3]: *** [subdir-clean-check] Error 2
make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[2]: *** [subdirs-clean] Error 2
make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[1]: *** [clean] Error 2
make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
make: *** [world] Error 2

[-- Attachment #1.2: Type: text/html, Size: 4638 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: build failure caused by $(XEN_ROOT)/.config

[Juergen Gross]

[-- Attachment #1.1: Type: text/plain, Size: 1367 bytes --]

On 10/04/2011 11:44 PM, Kay, Allen M wrote:
>
> Hi Keir,
>
> I'm getting the following build error caused by "-include 
> $(XEN_ROOT)/.config" line in Config.mk.  Removing it from Config.mk makes 
> the error go away.  The OS I'm using is FC15.  "$(XEN_ROOT)/.config" does 
> not exist.
>
> Allen
>
> -------
>
> make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
>
> make[4]: *** ../../.config: Is a directory.  Stop.
>
> make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
>
> make[3]: *** [subdir-clean-check] Error 2
>
> make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>
> make[2]: *** [subdirs-clean] Error 2
>
> make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>
> make[1]: *** [clean] Error 2
>
> make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
>
> make: *** [world] Error 2
>
>

This is fixed with cs 23049 in xen-unstable:

http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html


[-- Attachment #1.2: Type: text/html, Size: 5846 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

RE: build failure caused by $(XEN_ROOT)/.config

[Kay, Allen M]

[-- Attachment #1.1: Type: text/plain, Size: 1855 bytes --]

> This is fixed with cs 23049 in xen-unstable:

>

> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html



I'm using the latest staging tree (cs# 23903) and still seeing this problem.



Allen


From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Tuesday, October 04, 2011 9:45 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensource.com; keir@xen.org
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

On 10/04/2011 11:44 PM, Kay, Allen M wrote:
Hi Keir,

I'm getting the following build error caused by "-include $(XEN_ROOT)/.config" line in Config.mk.  Removing it from Config.mk makes the error go away.  The OS I'm using is FC15.  "$(XEN_ROOT)/.config" does not exist.

Allen

-------

make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[4]: *** ../../.config: Is a directory.  Stop.
make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[3]: *** [subdir-clean-check] Error 2
make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[2]: *** [subdirs-clean] Error 2
make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[1]: *** [clean] Error 2
make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
make: *** [world] Error 2


This is fixed with cs 23049 in xen-unstable:

http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html


Juergen


--

Juergen Gross                 Principal Developer Operating Systems

PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967

Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com<mailto:juergen.gross@ts.fujitsu.com>

Domagkstr. 28                           Internet: ts.fujitsu.com

D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

[-- Attachment #1.2: Type: text/html, Size: 7502 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: build failure caused by $(XEN_ROOT)/.config

[Keir Fraser]

[-- Attachment #1.1: Type: text/plain, Size: 1709 bytes --]

Perhaps we¹re best off just checking in an empty .config, and also adding it
to .hgignore.

 -- Keir

On 05/10/2011 17:24, "Kay, Allen M" <allen.m.kay@intel.com> wrote:

>> > This is fixed with cs 23049 in xen-unstable:
>> > 
>> > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
>  
> I¹m using the latest staging tree (cs# 23903) and still seeing this problem.
>  
> Allen
>  
>  
> 
> From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
> Sent: Tuesday, October 04, 2011 9:45 PM
> To: Kay, Allen M
> Cc: xen-devel@lists.xensource.com; keir@xen.org
> Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
>  
> On 10/04/2011 11:44 PM, Kay, Allen M wrote:
> Hi Keir,
>  
> I¹m getting the following build error caused by ³-include $(XEN_ROOT)/.config²
> line in Config.mk.  Removing it from Config.mk makes the error go away.  The
> OS I¹m using is FC15.  ³$(XEN_ROOT)/.config² does not exist.
>  
> Allen
>  
> -------
>  
> make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
> make[4]: *** ../../.config: Is a directory.  Stop.
> make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
> make[3]: *** [subdir-clean-check] Error 2
> make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
> make[2]: *** [subdirs-clean] Error 2
> make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
> make[1]: *** [clean] Error 2
> make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
> make: *** [world] Error 2
>  
> 
> This is fixed with cs 23049 in xen-unstable:
> 
> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
> 
> 
> Juergen


[-- Attachment #1.2: Type: text/html, Size: 3353 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: build failure caused by $(XEN_ROOT)/.config

[Keir Fraser]

[-- Attachment #1.1: Type: text/plain, Size: 1924 bytes --]

I¹ll add though that this bug doesn¹t happen for me, and I too am using F15.


On 05/10/2011 17:42, "Keir Fraser" <keir.xen@gmail.com> wrote:

> Perhaps we¹re best off just checking in an empty .config, and also adding it
> to .hgignore.
> 
>  -- Keir
> 
> On 05/10/2011 17:24, "Kay, Allen M" <allen.m.kay@intel.com> wrote:
> 
>>> > This is fixed with cs 23049 in xen-unstable:
>>> > 
>>> > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
>>  
>> I¹m using the latest staging tree (cs# 23903) and still seeing this problem.
>>  
>> Allen
>>  
>>  
>> 
>> From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
>> Sent: Tuesday, October 04, 2011 9:45 PM
>> To: Kay, Allen M
>> Cc: xen-devel@lists.xensource.com; keir@xen.org
>> Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
>>  
>> On 10/04/2011 11:44 PM, Kay, Allen M wrote:
>> Hi Keir,
>>  
>> I¹m getting the following build error caused by ³-include
>> $(XEN_ROOT)/.config² line in Config.mk.  Removing it from Config.mk makes the
>> error go away.  The OS I¹m using is FC15.  ³$(XEN_ROOT)/.config² does not
>> exist.
>>  
>> Allen
>>  
>> -------
>>  
>> make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
>> make[4]: *** ../../.config: Is a directory.  Stop.
>> make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
>> make[3]: *** [subdir-clean-check] Error 2
>> make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>> make[2]: *** [subdirs-clean] Error 2
>> make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>> make[1]: *** [clean] Error 2
>> make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
>> make: *** [world] Error 2
>>  
>> 
>> This is fixed with cs 23049 in xen-unstable:
>> 
>> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
>> 
>> 
>> Juergen
> 


[-- Attachment #1.2: Type: text/html, Size: 3795 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: build failure caused by $(XEN_ROOT)/.config

[Brendan Cully]

On Wednesday, 05 October 2011 at 17:42, Keir Fraser wrote:
> Perhaps we¹re best off just checking in an empty .config, and also adding it
> to .hgignore.

hg won't ignore checked-in files.

Re: build failure caused by $(XEN_ROOT)/.config

[Keir Fraser]

On 05/10/2011 17:47, "Brendan Cully" <brendan@cs.ubc.ca> wrote:

> On Wednesday, 05 October 2011 at 17:42, Keir Fraser wrote:
>> Perhaps we¹re best off just checking in an empty .config, and also adding it
>> to .hgignore.
> 
> hg won't ignore checked-in files.

I suppose that makes sense really. And of course .config is already in our
.hgignore.

 -- Keir

Re: build failure caused by $(XEN_ROOT)/.config

[Ian Campbell]

On Wed, 2011-10-05 at 17:51 +0100, Keir Fraser wrote:
> On 05/10/2011 17:47, "Brendan Cully" <brendan@cs.ubc.ca> wrote:
> 
> > On Wednesday, 05 October 2011 at 17:42, Keir Fraser wrote:
> >> Perhaps we¹re best off just checking in an empty .config, and also adding it
> >> to .hgignore.
> > 
> > hg won't ignore checked-in files.
> 
> I suppose that makes sense really. And of course .config is already in our
> .hgignore.

Can we convince Makefile to touch it if it doesn't exist?

Ian.

Re: build failure caused by $(XEN_ROOT)/.config

[Juergen Gross]

[-- Attachment #1.1: Type: text/plain, Size: 3073 bytes --]

Hi Allen,

On 10/05/2011 06:24 PM, Kay, Allen M wrote:
>
> > This is fixed with cs 23049 in xen-unstable:
>
> >
>
> > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
>
> I'm using the latest staging tree (cs# 23903) and still seeing this problem.
>

Uuh, the same bug was introduced again.
Could you try the following patch:

diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
--- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
+++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
@@ -1,4 +1,4 @@ XEN_ROOT = ../../..
-XEN_ROOT = ../../..
+XEN_ROOT = $(CURDIR)/../../..

  LIB_SRCS-y = fsys_xfs.c


Keir, it is easy to catch this problem: create a .config file in all directories
_above_ $XEN_ROOT containing something like:

$(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))


Juergen

> Allen
>
> *From:*Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
> *Sent:* Tuesday, October 04, 2011 9:45 PM
> *To:* Kay, Allen M
> *Cc:* xen-devel@lists.xensource.com; keir@xen.org
> *Subject:* Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
>
> On 10/04/2011 11:44 PM, Kay, Allen M wrote:
>
> Hi Keir,
>
> I'm getting the following build error caused by "-include 
> $(XEN_ROOT)/.config" line in Config.mk.  Removing it from Config.mk makes 
> the error go away.  The OS I'm using is FC15.  "$(XEN_ROOT)/.config" does 
> not exist.
>
> Allen
>
> -------
>
> make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
>
> make[4]: *** ../../.config: Is a directory.  Stop.
>
> make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
>
> make[3]: *** [subdir-clean-check] Error 2
>
> make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>
> make[2]: *** [subdirs-clean] Error 2
>
> make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>
> make[1]: *** [clean] Error 2
>
> make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
>
> make: *** [world] Error 2
>
>
> This is fixed with cs 23049 in xen-unstable:
>
> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
>
>
> Juergen
>
> -- 
> Juergen Gross                 Principal Developer Operating Systems
> PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
> Fujitsu Technology Solutions              e-mail:juergen.gross@ts.fujitsu.com  <mailto:juergen.gross@ts.fujitsu.com>
> Domagkstr. 28                           Internet: ts.fujitsu.com
> D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


-- 
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html


[-- Attachment #1.2: Type: text/html, Size: 11215 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: build failure caused by $(XEN_ROOT)/.config

[Keir Fraser]

On 06/10/2011 05:40, "Juergen Gross" <juergen.gross@ts.fujitsu.com> wrote:

>  
>  Uuh, the same bug was introduced again.
>  Could you try the following patch:

Whilst this is definitely a valid fix, Allen's build was crashing out from
tools/check. This is unlikely to fix it.

 -- Keir

>  diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
>  --- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
>  +++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
>  @@ -1,4 +1,4 @@ XEN_ROOT = ../../..
>  -XEN_ROOT = ../../..
>  +XEN_ROOT = $(CURDIR)/../../..
>   
>   LIB_SRCS-y = fsys_xfs.c
>   
>  
>  Keir, it is easy to catch this problem: create a .config file in all
> directories
>  _above_ $XEN_ROOT containing something like:
>  
>  $(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))
>  
>  
>  Juergen
>  
>  
>>  
>>  
>> 
>>  
>>  
>>  
>> Allen
>>  
>>  
>>  
>>  
>>  
>>  
>>  
>> 
>> From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
>>  Sent: Tuesday, October 04, 2011 9:45 PM
>>  To: Kay, Allen M
>>  Cc: xen-devel@lists.xensource.com; keir@xen.org
>>  Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
>>  
>>  
>>  
>>  
>>  
>> On 10/04/2011 11:44 PM, Kay, Allen M wrote:
>>  
>> Hi Keir,
>>  
>>  
>>  
>> I¹m getting the following build error caused by ³-include
>> $(XEN_ROOT)/.config² line in Config.mk.  Removing it from Config.mk makes the
>> error go away.  The OS I¹m using is FC15.  ³$(XEN_ROOT)/.config² does not
>> exist.
>>  
>>  
>>  
>> Allen
>>  
>>  
>>  
>> -------
>>  
>>  
>>  
>> make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
>>  
>> make[4]: *** ../../.config: Is a directory.  Stop.
>>  
>> make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
>>  
>> make[3]: *** [subdir-clean-check] Error 2
>>  
>> make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>>  
>> make[2]: *** [subdirs-clean] Error 2
>>  
>> make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>>  
>> make[1]: *** [clean] Error 2
>>  
>> make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
>>  
>> make: *** [world] Error 2
>>  
>>  
>>  
>> 
>>  This is fixed with cs 23049 in xen-unstable:
>>  
>>  http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
>>  
>>  
>>  Juergen
>>  
>>  
>>  

Re: build failure caused by $(XEN_ROOT)/.config

[Juergen Gross]

On 10/06/2011 10:00 AM, Keir Fraser wrote:
> On 06/10/2011 05:40, "Juergen Gross"<juergen.gross@ts.fujitsu.com>  wrote:
>
>>
>>   Uuh, the same bug was introduced again.
>>   Could you try the following patch:
> Whilst this is definitely a valid fix, Allen's build was crashing out from
> tools/check. This is unlikely to fix it.

His build path suggests he is using xen-4.1-testing. cs23049 was applied directly
after branching xen 4.1.
In the current staging tree my patch fixes a similar problem in a different
Makefile.

Allen, which version are you really using?


Juergen

>>   diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
>>   --- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
>>   +++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
>>   @@ -1,4 +1,4 @@ XEN_ROOT = ../../..
>>   -XEN_ROOT = ../../..
>>   +XEN_ROOT = $(CURDIR)/../../..
>>
>>    LIB_SRCS-y = fsys_xfs.c
>>
>>
>>   Keir, it is easy to catch this problem: create a .config file in all
>> directories
>>   _above_ $XEN_ROOT containing something like:
>>
>>   $(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))
>>
>>
>>   Juergen
>>
>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> Allen
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
>>>   Sent: Tuesday, October 04, 2011 9:45 PM
>>>   To: Kay, Allen M
>>>   Cc: xen-devel@lists.xensource.com; keir@xen.org
>>>   Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
>>>
>>>
>>>
>>>
>>>
>>> On 10/04/2011 11:44 PM, Kay, Allen M wrote:
>>>
>>> Hi Keir,
>>>
>>>
>>>
>>> I¹m getting the following build error caused by ³-include
>>> $(XEN_ROOT)/.config² line in Config.mk.  Removing it from Config.mk makes the
>>> error go away.  The OS I¹m using is FC15.  ³$(XEN_ROOT)/.config² does not
>>> exist.
>>>
>>>
>>>
>>> Allen
>>>
>>>
>>>
>>> -------
>>>
>>>
>>>
>>> make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
>>>
>>> make[4]: *** ../../.config: Is a directory.  Stop.
>>>
>>> make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
>>>
>>> make[3]: *** [subdir-clean-check] Error 2
>>>
>>> make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>>>
>>> make[2]: *** [subdirs-clean] Error 2
>>>
>>> make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
>>>
>>> make[1]: *** [clean] Error 2
>>>
>>> make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
>>>
>>> make: *** [world] Error 2
>>>
>>>
>>>
>>>
>>>   This is fixed with cs 23049 in xen-unstable:
>>>
>>>   http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
>>>
>>>
>>>   Juergen
>>>
>>>
>>>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>


-- 
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Re: build failure caused by $(XEN_ROOT)/.config

[Ian Jackson]

Juergen Gross writes ("Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.conf> His build path suggests he is using xen-4.1-testing. cs23049 was applied directly
> after branching xen 4.1.
> In the current staging tree my patch fixes a similar problem in a different
> Makefile.
> 
> Allen, which version are you really using?

To summarise, it sounds like we need to backport 23049 to 4.1 but also
to apply Juergen's patch to libfsimage ?

Ian.

Re: build failure caused by $(XEN_ROOT)/.config

[Keir Fraser]

On 06/10/2011 18:46, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:

> Juergen Gross writes ("Re: [Xen-devel] build failure caused by
> $(XEN_ROOT)/.conf> His build path suggests he is using xen-4.1-testing.
> cs23049 was applied directly
>> after branching xen 4.1.
>> In the current staging tree my patch fixes a similar problem in a different
>> Makefile.
>> 
>> Allen, which version are you really using?
> 
> To summarise, it sounds like we need to backport 23049 to 4.1 but also
> to apply Juergen's patch to libfsimage ?

Sounds about right. If you want to do an equivalent patch to 23049 in 4.1
feel free to go ahead. I'll hold back -rc3 in that case.

 -- Keir

> Ian.

RE: build failure caused by $(XEN_ROOT)/.config

[Kay, Allen M]

[-- Attachment #1.1: Type: text/plain, Size: 3647 bytes --]

Hi Juergen,

This patch fixes the build problem for xen-unstable but do not apply to xen-4.1-testing.  Xen-4.1-testing do not have xfs directory and still has the same build error.

Allen

From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Wednesday, October 05, 2011 9:41 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensource.com; keir@xen.org
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

Hi Allen,

On 10/05/2011 06:24 PM, Kay, Allen M wrote:

> This is fixed with cs 23049 in xen-unstable:

>

> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html



I'm using the latest staging tree (cs# 23903) and still seeing this problem.

Uuh, the same bug was introduced again.
Could you try the following patch:

diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
--- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
+++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
@@ -1,4 +1,4 @@ XEN_ROOT = ../../..
-XEN_ROOT = ../../..
+XEN_ROOT = $(CURDIR)/../../..

 LIB_SRCS-y = fsys_xfs.c


Keir, it is easy to catch this problem: create a .config file in all directories
_above_ $XEN_ROOT containing something like:

$(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))


Juergen





Allen


From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Tuesday, October 04, 2011 9:45 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensource.com<mailto:xen-devel@lists.xensource.com>; keir@xen.org<mailto:keir@xen.org>
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

On 10/04/2011 11:44 PM, Kay, Allen M wrote:
Hi Keir,

I'm getting the following build error caused by "-include $(XEN_ROOT)/.config" line in Config.mk.  Removing it from Config.mk makes the error go away.  The OS I'm using is FC15.  "$(XEN_ROOT)/.config" does not exist.

Allen

-------

make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[4]: *** ../../.config: Is a directory.  Stop.
make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[3]: *** [subdir-clean-check] Error 2
make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[2]: *** [subdirs-clean] Error 2
make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[1]: *** [clean] Error 2
make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
make: *** [world] Error 2


This is fixed with cs 23049 in xen-unstable:

http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html


Juergen



--

Juergen Gross                 Principal Developer Operating Systems

PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967

Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com<mailto:juergen.gross@ts.fujitsu.com>

Domagkstr. 28                           Internet: ts.fujitsu.com

D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html





_______________________________________________

Xen-devel mailing list

Xen-devel@lists.xensource.com<mailto:Xen-devel@lists.xensource.com>

http://lists.xensource.com/xen-devel




--

Juergen Gross                 Principal Developer Operating Systems

PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967

Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com<mailto:juergen.gross@ts.fujitsu.com>

Domagkstr. 28                           Internet: ts.fujitsu.com

D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

[-- Attachment #1.2: Type: text/html, Size: 11762 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

RE: build failure caused by $(XEN_ROOT)/.config

[Ian Jackson]

Kay, Allen M writes ("RE: [Xen-devel] build failure caused by $(XEN_ROOT)/.config"):
> This patch fixes the build problem for xen-unstable but do not apply to
> xen-4.1-testing.  Xen-4.1-testing do not have xfs directory and still has the
> same build error.

Right, so Juergen's patch is good for unstable.  Juergen, can I have a
signoff, and then I'll apply it ?

Ian.

RE: build failure caused by $(XEN_ROOT)/.config

[Kay, Allen M]

[-- Attachment #1.1: Type: text/plain, Size: 4406 bytes --]

Here is the exact build error I get in xen-4.1-testing:

make[4]: Entering directory `/tmp/xen-4.1-testing.hg/tools/check'
make[4]: *** ../../.config: Is a directory.  Stop.
make[4]: Leaving directory `/tmp/xen-4.1-testing.hg/tools/check'
make[3]: *** [subdir-clean-check] Error 2
make[3]: Leaving directory `/tmp/xen-4.1-testing.hg/tools'
make[2]: *** [subdirs-clean] Error 2
make[2]: Leaving directory `/tmp/xen-4.1-testing.hg/tools'
make[1]: *** [clean] Error 2
make[1]: Leaving directory `/tmp/xen-4.1-testing.hg'
make: *** [world] Error 2


From: Kay, Allen M
Sent: Thursday, October 06, 2011 11:18 AM
To: 'Juergen Gross'
Cc: xen-devel@lists.xensource.com; keir@xen.org
Subject: RE: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

Hi Juergen,

This patch fixes the build problem for xen-unstable but do not apply to xen-4.1-testing.  Xen-4.1-testing do not have xfs directory and still has the same build error.

Allen

From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Wednesday, October 05, 2011 9:41 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensource.com; keir@xen.org
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

Hi Allen,

On 10/05/2011 06:24 PM, Kay, Allen M wrote:

> This is fixed with cs 23049 in xen-unstable:

>

> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html



I'm using the latest staging tree (cs# 23903) and still seeing this problem.

Uuh, the same bug was introduced again.
Could you try the following patch:

diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
--- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
+++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
@@ -1,4 +1,4 @@ XEN_ROOT = ../../..
-XEN_ROOT = ../../..
+XEN_ROOT = $(CURDIR)/../../..

 LIB_SRCS-y = fsys_xfs.c


Keir, it is easy to catch this problem: create a .config file in all directories
_above_ $XEN_ROOT containing something like:

$(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))


Juergen




Allen


From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Tuesday, October 04, 2011 9:45 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensource.com<mailto:xen-devel@lists.xensource.com>; keir@xen.org<mailto:keir@xen.org>
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

On 10/04/2011 11:44 PM, Kay, Allen M wrote:
Hi Keir,

I'm getting the following build error caused by "-include $(XEN_ROOT)/.config" line in Config.mk.  Removing it from Config.mk makes the error go away.  The OS I'm using is FC15.  "$(XEN_ROOT)/.config" does not exist.

Allen

-------

make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[4]: *** ../../.config: Is a directory.  Stop.
make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[3]: *** [subdir-clean-check] Error 2
make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[2]: *** [subdirs-clean] Error 2
make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[1]: *** [clean] Error 2
make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
make: *** [world] Error 2


This is fixed with cs 23049 in xen-unstable:

http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html


Juergen


--

Juergen Gross                 Principal Developer Operating Systems

PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967

Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com<mailto:juergen.gross@ts.fujitsu.com>

Domagkstr. 28                           Internet: ts.fujitsu.com

D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html





_______________________________________________

Xen-devel mailing list

Xen-devel@lists.xensource.com<mailto:Xen-devel@lists.xensource.com>

http://lists.xensource.com/xen-devel



--

Juergen Gross                 Principal Developer Operating Systems

PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967

Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com<mailto:juergen.gross@ts.fujitsu.com>

Domagkstr. 28                           Internet: ts.fujitsu.com

D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

[-- Attachment #1.2: Type: text/html, Size: 14057 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: build failure caused by $(XEN_ROOT)/.config

[Keir Fraser]

[-- Attachment #1.1: Type: text/plain, Size: 3911 bytes --]

Yes, as Ian Jackson has noted, this is because the fix for this in
xen-unstable has not been backported. I think Ian Jackson may be proposing
to do the backport. If not, you¹ll just have to manually Œtouch .config¹ at
the root of your Xen repository, and get on with that.

 -- Keir


On 06/10/2011 19:27, "Kay, Allen M" <allen.m.kay@intel.com> wrote:

> Here is the exact build error I get in xen-4.1-testing:
>  
> make[4]: Entering directory `/tmp/xen-4.1-testing.hg/tools/check'
> make[4]: *** ../../.config: Is a directory.  Stop.
> make[4]: Leaving directory `/tmp/xen-4.1-testing.hg/tools/check'
> make[3]: *** [subdir-clean-check] Error 2
> make[3]: Leaving directory `/tmp/xen-4.1-testing.hg/tools'
> make[2]: *** [subdirs-clean] Error 2
> make[2]: Leaving directory `/tmp/xen-4.1-testing.hg/tools'
> make[1]: *** [clean] Error 2
> make[1]: Leaving directory `/tmp/xen-4.1-testing.hg'
> make: *** [world] Error 2
>  
>  
> 
> From: Kay, Allen M
> Sent: Thursday, October 06, 2011 11:18 AM
> To: 'Juergen Gross'
> Cc: xen-devel@lists.xensource.com; keir@xen.org
> Subject: RE: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
>  
> Hi Juergen,
>  
> This patch fixes the build problem for xen-unstable but do not apply to
> xen-4.1-testing.  Xen-4.1-testing do not have xfs directory and still has the
> same build error.
>  
> Allen
>  
> 
> From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
> Sent: Wednesday, October 05, 2011 9:41 PM
> To: Kay, Allen M
> Cc: xen-devel@lists.xensource.com; keir@xen.org
> Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
>  
> Hi Allen,
> 
> On 10/05/2011 06:24 PM, Kay, Allen M wrote:
>> > This is fixed with cs 23049 in xen-unstable:
>> > 
>> > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
>  
> I¹m using the latest staging tree (cs# 23903) and still seeing this problem.
> 
> Uuh, the same bug was introduced again.
> Could you try the following patch:
> 
> diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
> --- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
> +++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
> @@ -1,4 +1,4 @@ XEN_ROOT = ../../..
> -XEN_ROOT = ../../..
> +XEN_ROOT = $(CURDIR)/../../..
>  
>  LIB_SRCS-y = fsys_xfs.c
>  
> 
> Keir, it is easy to catch this problem: create a .config file in all
> directories
> _above_ $XEN_ROOT containing something like:
> 
> $(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))
> 
> 
> Juergen
> 
> 
>  
> Allen
>  
>  
> 
> From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
> Sent: Tuesday, October 04, 2011 9:45 PM
> To: Kay, Allen M
> Cc: xen-devel@lists.xensource.com; keir@xen.org
> Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
>  
> On 10/04/2011 11:44 PM, Kay, Allen M wrote:
> Hi Keir,
>  
> I¹m getting the following build error caused by ³-include $(XEN_ROOT)/.config²
> line in Config.mk.  Removing it from Config.mk makes the error go away.  The
> OS I¹m using is FC15.  ³$(XEN_ROOT)/.config² does not exist.
>  
> Allen
>  
> -------
>  
> make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
> make[4]: *** ../../.config: Is a directory.  Stop.
> make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
> make[3]: *** [subdir-clean-check] Error 2
> make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
> make[2]: *** [subdirs-clean] Error 2
> make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
> make[1]: *** [clean] Error 2
> make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
> make: *** [world] Error 2
>  
> 
> This is fixed with cs 23049 in xen-unstable:
> 
> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
> 
> 
> Juergen


[-- Attachment #1.2: Type: text/html, Size: 6807 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

RE: build failure caused by $(XEN_ROOT)/.config

[Kay, Allen M]

[-- Attachment #1.1: Type: text/plain, Size: 4024 bytes --]

I have tried "touch .config" and it works.   I provided the error messages as FYI in case you guys needed it.

Allen

From: Keir Fraser [mailto:keir.xen@gmail.com]
Sent: Thursday, October 06, 2011 11:33 AM
To: Kay, Allen M; Juergen Gross
Cc: xen-devel@lists.xensource.com; Ian Jackson
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

Yes, as Ian Jackson has noted, this is because the fix for this in xen-unstable has not been backported. I think Ian Jackson may be proposing to do the backport. If not, you'll just have to manually 'touch .config' at the root of your Xen repository, and get on with that.

 -- Keir


On 06/10/2011 19:27, "Kay, Allen M" <allen.m.kay@intel.com> wrote:
Here is the exact build error I get in xen-4.1-testing:

make[4]: Entering directory `/tmp/xen-4.1-testing.hg/tools/check'
make[4]: *** ../../.config: Is a directory.  Stop.
make[4]: Leaving directory `/tmp/xen-4.1-testing.hg/tools/check'
make[3]: *** [subdir-clean-check] Error 2
make[3]: Leaving directory `/tmp/xen-4.1-testing.hg/tools'
make[2]: *** [subdirs-clean] Error 2
make[2]: Leaving directory `/tmp/xen-4.1-testing.hg/tools'
make[1]: *** [clean] Error 2
make[1]: Leaving directory `/tmp/xen-4.1-testing.hg'
make: *** [world] Error 2



From: Kay, Allen M
Sent: Thursday, October 06, 2011 11:18 AM
To: 'Juergen Gross'
Cc: xen-devel@lists.xensource.com; keir@xen.org
Subject: RE: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

Hi Juergen,

This patch fixes the build problem for xen-unstable but do not apply to xen-4.1-testing.  Xen-4.1-testing do not have xfs directory and still has the same build error.

Allen


From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Wednesday, October 05, 2011 9:41 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensource.com; keir@xen.org
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

Hi Allen,

On 10/05/2011 06:24 PM, Kay, Allen M wrote:
> This is fixed with cs 23049 in xen-unstable:
>
> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html

I'm using the latest staging tree (cs# 23903) and still seeing this problem.

Uuh, the same bug was introduced again.
Could you try the following patch:

diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
--- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
+++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
@@ -1,4 +1,4 @@ XEN_ROOT = ../../..
-XEN_ROOT = ../../..
+XEN_ROOT = $(CURDIR)/../../..

 LIB_SRCS-y = fsys_xfs.c


Keir, it is easy to catch this problem: create a .config file in all directories
_above_ $XEN_ROOT containing something like:

$(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))


Juergen



Allen



From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Tuesday, October 04, 2011 9:45 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensource.com; keir@xen.org
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

On 10/04/2011 11:44 PM, Kay, Allen M wrote:
Hi Keir,

I'm getting the following build error caused by "-include $(XEN_ROOT)/.config" line in Config.mk.  Removing it from Config.mk makes the error go away.  The OS I'm using is FC15.  "$(XEN_ROOT)/.config" does not exist.

Allen

-------

make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[4]: *** ../../.config: Is a directory.  Stop.
make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
make[3]: *** [subdir-clean-check] Error 2
make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[2]: *** [subdirs-clean] Error 2
make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
make[1]: *** [clean] Error 2
make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
make: *** [world] Error 2


This is fixed with cs 23049 in xen-unstable:

http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html


Juergen

[-- Attachment #1.2: Type: text/html, Size: 9260 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: build failure caused by $(XEN_ROOT)/.config

[Ian Jackson]

Keir Fraser writes ("Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config"):
> Yes, as Ian Jackson has noted, this is because the fix for this in xen-unstable has not been backported. I think Ian Jackson may be proposing to do the backport. If not, you’ll just have to manually ‘touch .config’ at the root of your Xen repository, and get on with that.

23049:ff3b7749008b applied cleanly to 4.1 and seems to build for me,
so I have pushed it.

Let's wait with doing another RC until we see that the automated
tester is happy with it :-).

Ian.