From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: build failure caused by $(XEN_ROOT)/.config Date: Thu, 06 Oct 2011 06:40:31 +0200 Message-ID: <4E8D313F.8040809@ts.fujitsu.com> References: <987664A83D2D224EAE907B061CE93D5301EE62D025@orsmsx505.amr.corp.intel.com> <4E8BE0DB.7040503@ts.fujitsu.com> <987664A83D2D224EAE907B061CE93D5301EE62D5F4@orsmsx505.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1146125881==" Return-path: In-Reply-To: <987664A83D2D224EAE907B061CE93D5301EE62D5F4@orsmsx505.amr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Kay, Allen M" Cc: "xen-devel@lists.xensource.com" , "keir@xen.org" List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============1146125881== Content-Type: multipart/alternative; boundary="------------090207080709080501090407" This is a multi-part message in MIME format. --------------090207080709080501090407 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Allen, On 10/05/2011 06:24 PM, Kay, Allen M wrote: > > > This is fixed with cs 23049 in xen-unstable: > > > > > > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html > > I'm using the latest staging tree (cs# 23903) and still seeing this problem. > Uuh, the same bug was introduced again. Could you try the following patch: diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile --- a/tools/libfsimage/xfs/Makefile Tue Oct 04 14:18:30 2011 +0200 +++ b/tools/libfsimage/xfs/Makefile Thu Oct 06 06:32:00 2011 +0200 @@ -1,4 +1,4 @@ XEN_ROOT = ../../.. -XEN_ROOT = ../../.. +XEN_ROOT = $(CURDIR)/../../.. LIB_SRCS-y = fsys_xfs.c Keir, it is easy to catch this problem: create a .config file in all directories _above_ $XEN_ROOT containing something like: $(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST)) Juergen > Allen > > *From:*Juergen Gross [mailto:juergen.gross@ts.fujitsu.com] > *Sent:* Tuesday, October 04, 2011 9:45 PM > *To:* Kay, Allen M > *Cc:* xen-devel@lists.xensource.com; keir@xen.org > *Subject:* Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config > > On 10/04/2011 11:44 PM, Kay, Allen M wrote: > > Hi Keir, > > I'm getting the following build error caused by "-include > $(XEN_ROOT)/.config" line in Config.mk. Removing it from Config.mk makes > the error go away. The OS I'm using is FC15. "$(XEN_ROOT)/.config" does > not exist. > > Allen > > ------- > > make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check' > > make[4]: *** ../../.config: Is a directory. Stop. > > make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check' > > make[3]: *** [subdir-clean-check] Error 2 > > make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools' > > make[2]: *** [subdirs-clean] Error 2 > > make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools' > > make[1]: *** [clean] Error 2 > > make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg' > > make: *** [world] Error 2 > > > This is fixed with cs 23049 in xen-unstable: > > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html > > > Juergen > > -- > Juergen Gross Principal Developer Operating Systems > PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 > Fujitsu Technology Solutions e-mail:juergen.gross@ts.fujitsu.com > Domagkstr. 28 Internet: ts.fujitsu.com > D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel -- Juergen Gross Principal Developer Operating Systems PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html --------------090207080709080501090407 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi Allen,

On 10/05/2011 06:24 PM, Kay, Allen M wrote:

> This is fixed with cs 23049 in xen-unstable:

>

> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html

 

I’m using the latest staging tree (cs# 23903) and still seeing this problem.


Uuh, the same bug was introduced again.
Could you try the following patch:

diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
--- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
+++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
@@ -1,4 +1,4 @@ XEN_ROOT = ../../..
-XEN_ROOT = ../../..
+XEN_ROOT = $(CURDIR)/../../..
 
 LIB_SRCS-y = fsys_xfs.c
 

Keir, it is easy to catch this problem: create a .config file in all directories
_above_ $XEN_ROOT containing something like:

$(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))


Juergen

 

Allen

 

 

From: Juergen Gross [mailto:juergen.gross@ts.fujitsu.com]
Sent: Tuesday, October 04, 2011 9:45 PM
To: Kay, Allen M
Cc: xen-devel@lists.xensource.com; keir@xen.org
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

 

On 10/04/2011 11:44 PM, Kay, Allen M wrote:

Hi Keir,

 

I’m getting the following build error caused by “-include $(XEN_ROOT)/.config” line in Config.mk.  Removing it from Config.mk makes the error go away.  The OS I’m using is FC15.  “$(XEN_ROOT)/.config” does not exist.

 

Allen

 

-------

 

make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'

make[4]: *** ../../.config: Is a directory.  Stop.

make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'

make[3]: *** [subdir-clean-check] Error 2

make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'

make[2]: *** [subdirs-clean] Error 2

make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'

make[1]: *** [clean] Error 2

make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'

make: *** [world] Error 2

 


This is fixed with cs 23049 in xen-unstable:

http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



-- 
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html
--------------090207080709080501090407-- --===============1146125881== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1146125881==--