All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] savevm: improve subsections detection on load
Date: Thu, 06 Oct 2011 10:38:56 +0200	[thread overview]
Message-ID: <4E8D6920.1020003@redhat.com> (raw)
In-Reply-To: <4E8CB3DB.7020204@codemonkey.ws>

On 10/05/2011 09:45 PM, Anthony Liguori wrote:
>>
>>   int qemu_get_buffer(QEMUFile *f, uint8_t *buf, int size1)
>>   {
>>       int size, l;
>
> Can we implement get_buffer in terms of peek_buffer and just increment
> f->buf_index in get_buffer?

No, get_buffer works even if size1 is greater than the size of the 
buffer, peek_buffer doesn't.

Paolo

  reply	other threads:[~2011-10-06  8:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 14:38 [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection Juan Quintela
2011-10-04 14:38 ` [Qemu-devel] [PATCH 1/4] savevm: teach qemu_fill_buffer to do partial refills Juan Quintela
2011-10-05 19:41   ` Anthony Liguori
2011-10-04 14:38 ` [Qemu-devel] [PATCH 2/4] savevm: some coding style cleanups Juan Quintela
2011-10-05 19:41   ` Anthony Liguori
2011-10-04 14:38 ` [Qemu-devel] [PATCH 3/4] savevm: improve subsections detection on load Juan Quintela
2011-10-05 19:45   ` Anthony Liguori
2011-10-06  8:38     ` Paolo Bonzini [this message]
2011-10-04 14:38 ` [Qemu-devel] [PATCH 4/4] Revert "savevm: fix corruption in vmstate_subsection_load()." Juan Quintela
2011-10-05 19:46   ` Anthony Liguori
2011-10-04 15:12 ` [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection Paolo Bonzini
2011-10-04 18:20 ` Avi Kivity
2011-10-04 18:22   ` Anthony Liguori
2011-10-04 18:28     ` Avi Kivity
2011-10-04 18:35   ` Juan Quintela
2011-10-04 18:37     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8D6920.1020003@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.