All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 3/3] Change default prefix.
Date: Thu, 06 Oct 2011 11:49:31 +0200	[thread overview]
Message-ID: <4E8D79AB.9030604@redhat.com> (raw)
In-Reply-To: <da81bee4945606f90a6a737f2d693d300b7d8246.1317893838.git.zkabelac@redhat.com>

Dne 6.10.2011 11:43, Zdenek Kabelac napsal(a):
> Use ""  instead of "  ".
> So commands like lvs print from the begining of the line.
> (no need to trim space around).
>
> Signed-off-by: Zdenek Kabelac<zkabelac@redhat.com>
> ---
>   doc/example.conf.in   |    6 +++---
>   lib/config/defaults.h |    6 +++++-
>   2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/doc/example.conf.in b/doc/example.conf.in
> index d38f90e..58748cc 100644
> --- a/doc/example.conf.in
> +++ b/doc/example.conf.in
> @@ -248,9 +248,9 @@ log {
>       command_names = 0
>
>       # A prefix to use before the message text (but after the command name,
> -    # if selected).  Default is two spaces, so you can see/grep the severity
> -    # of each message.
> -    prefix = "  "
> +    # if selected). Set to "  " to revert to the default behaviour
> +    # prior to version 2.02.89.
> +    prefix = ""
>
>       # To make the messages look similar to the original LVM tools use:
>       #   indent = 0
> diff --git a/lib/config/defaults.h b/lib/config/defaults.h
> index be016f6..df1dcba 100644
> --- a/lib/config/defaults.h
> +++ b/lib/config/defaults.h
> @@ -99,7 +99,11 @@
>   #define DEFAULT_MAXIMISE_CLING 1
>   #define DEFAULT_CLUSTERED 0
>
> -#define DEFAULT_MSG_PREFIX "  "
> +/*
> + * NOTE: _find_config_str() does not allow empty string "",
> + * but when the default msg prefix is also "" it works as expected.
> + */
> +#define DEFAULT_MSG_PREFIX ""

The comment here is not true anymore with patch 2/3 as I've reorderd patch set 
somewhat. So committed version will not have it.

Zdenek



  reply	other threads:[~2011-10-06  9:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06  9:42 [PATCH 0/3] Allow empty prefix Zdenek Kabelac
2011-10-06  9:43 ` [PATCH 1/3] Fix core on buggy config file Zdenek Kabelac
2011-10-06  9:43 ` [PATCH 2/3] Add find_config_tree_str_allow_empty Zdenek Kabelac
2011-10-06  9:43 ` [PATCH 3/3] Change default prefix Zdenek Kabelac
2011-10-06  9:49   ` Zdenek Kabelac [this message]
2011-10-26 11:19   ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8D79AB.9030604@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.