From: Nick Dyer <nick.dyer@itdev.co.uk>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Iiro Valkonen <iiro.valkonen@atmel.com>,
Henrik Rydberg <rydberg@euromail.se>,
Yufeng Shen <miletus@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: atmel_mxt_ts - Use snprintf for sysfs attribute show method
Date: Thu, 06 Oct 2011 10:59:23 +0100 [thread overview]
Message-ID: <4E8D7BFB.4070706@itdev.co.uk> (raw)
In-Reply-To: <1316115647-1244-1-git-send-email-djkurtz@chromium.org>
Hi Daniel-
Just to introduce myself, I'm working for Atmel in UK on the
atmel_mxt_ts driver.
Daniel Kurtz wrote:
> Sysfs attribute show methods are always passed a buffer of length
> PAGE_SIZE. To keep from overwriting this buffer and causing havoc,
> use snprintf() to guarantee we never write more than the buffer can
> hold.
>
> In addition, at least for my touchscreen, the number and size of
> objects was far too big to fit in a single 4K page. Therefore, this
> patch also trims some redundant framing text to leave more room for
> actual data.
Yes, I'd noticed this problem as well. I was planning to address it by
splitting up the file, but your patch looks like a good solution for now.
I've tested it successfully on several chips.
Acked-by: Nick Dyer <nick.dyer@itdev.co.uk>
--
Nick Dyer
Software Engineer, ITDev Ltd
Hardware and Software Development Consultancy
Email: nick.dyer@itdev.co.uk
Website: http://www.itdev.co.uk
next prev parent reply other threads:[~2011-10-06 10:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 19:40 [PATCH] Input: atmel_mxt_ts - Use snprintf for sysfs attribute show method Daniel Kurtz
2011-09-16 0:52 ` Joonyoung Shim
2011-09-16 0:52 ` Joonyoung Shim
2011-09-16 5:10 ` Daniel Kurtz
2011-09-16 5:10 ` Daniel Kurtz
2011-09-20 12:57 ` Iiro Valkonen
2011-10-06 9:59 ` Nick Dyer [this message]
2011-10-19 7:40 ` Daniel Kurtz
2011-10-19 17:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8D7BFB.4070706@itdev.co.uk \
--to=nick.dyer@itdev.co.uk \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=iiro.valkonen@atmel.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.