From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Thu, 06 Oct 2011 13:19:24 +0200
Subject: [U-Boot] [PATCH v2 1/3] misc:pmic:core New generic PMIC driver
In-Reply-To: <20111006131327.72af23d8@lmajewski.digital.local>
References: <1314868412-2949-1-git-send-email-l.majewski@samsung.com>
	<1317707151-21803-1-git-send-email-l.majewski@samsung.com>
	<1317707151-21803-2-git-send-email-l.majewski@samsung.com>
	<4E8D7982.4070403@denx.de>
	<20111006131327.72af23d8@lmajewski.digital.local>
Message-ID: <4E8D8EBC.9090704@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/06/2011 01:13 PM, Lukasz Majewski wrote:
> Hi Stefano,
> 

Hi Lukasz,

> I suppose you are talking about cases like the following:
> 
>> #define CONFIG_SPI_FLASH_CS		(1 | 121 << 8)
> 
> Yes, this construct will cause range overflow.
> 
>> +struct p_spi {
>> +	unsigned char cs;
>> +	unsigned char mode;
>> +	unsigned char bitlen;
> 
> Therefore the above variables need to be at least unsigned shorts.
> As you proposed they shall be unsigned int.

Yes

> 
> On technical question:
> Shall I prepare the whole v3 patch series or only v3 for this single
> patch ([PATCH v2 1/3] misc:pmic:core New generic PMIC drive)?

Post only v3 for the single patch.

> 
> What would be easier for You or Wolfgang to pick?

As Wolfgang asked, I will take care of your patchset and I will merge it
with u-boot-imx. It will go into mainline after my pull request.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================