From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RBpPf-0002s0-Ml for mharc-grub-devel@gnu.org; Thu, 06 Oct 2011 10:59:07 -0400 Received: from eggs.gnu.org ([140.186.70.92]:48332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBpPd-0002ru-7A for grub-devel@gnu.org; Thu, 06 Oct 2011 10:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBpPb-0005eg-Ne for grub-devel@gnu.org; Thu, 06 Oct 2011 10:59:05 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:38745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBpPb-0005eY-JD for grub-devel@gnu.org; Thu, 06 Oct 2011 10:59:03 -0400 Received: by wwp14 with SMTP id 14so3702924wwp.30 for ; Thu, 06 Oct 2011 07:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; bh=/JYSvSOA/xbj8aguoW2CH8Ragg3+nbbdxmM9xQbMyIk=; b=CZ7G8vx+9KtiHcgweCwlkJd6U/aHS7n6+ekcAbiLvjoWA7Hp4OY4bk/EdAfDp7QPTz x2AjXsry8GAHGIDwua4ak2R/pJCmZ1lNdXhX3hd5SCNuBQvC5CPLuo1RLkAt0heJFUZf QXil8zP+NJwPIuWelvaIxAECH0YldlB+FBC+E= Received: by 10.227.195.145 with SMTP id ec17mr1116122wbb.0.1317913142126; Thu, 06 Oct 2011 07:59:02 -0700 (PDT) Received: from debian.x201.phnet (gprs33.swisscom-mobile.ch. [193.247.250.33]) by mx.google.com with ESMTPS id z9sm10618474wbn.19.2011.10.06.07.58.58 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Oct 2011 07:58:59 -0700 (PDT) Message-ID: <4E8DC22A.1030000@gmail.com> Date: Thu, 06 Oct 2011 16:58:50 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20111005 Iceowl/1.0b2 Icedove/3.1.15 MIME-Version: 1.0 To: Szymon Janc Subject: Re: [RFC] LZO support References: <201109142120.06740.szymon@janc.net.pl> <4E83940C.8060601@gmail.com> <201110042211.40185.szymon@janc.net.pl> In-Reply-To: <201110042211.40185.szymon@janc.net.pl> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigCFE34AFA5BB5E817DCB848A1" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.49 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2011 14:59:06 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCFE34AFA5BB5E817DCB848A1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Looks good. You can commit it upstream. On 04.10.2011 22:11, Szymon Janc wrote: > On Wednesday 28 September 2011 23:39:24 Vladimir '=CF=86-coder/phcoder'= Serbinenko=20 > wrote: >> On 14.09.2011 21:20, Szymon Janc wrote: >>> Hello, >>> >>> I've implemented support for LZO in grub, this includes: >>> - import of minilzo library (from [1]) >>> - support for LZO (de)compression in btrfs (compress=3Dlzo mount opti= on) >>> - lzopio - for reading lzop compressed files >> + common =3D lib/minilzo/minilzo.c; >> @@ -1650,6 +1653,14 @@ >> + common =3D lib/minilzo/minilzo.c; >> Please don't include same file twice in different modules it creates a= >> symbol conflict. It's ok to have btrfs depend on lzopio if necessary, = at >> least for now. > Done. > >> +#include "minilzo.h" >> I'd prefer and an explicit -I on cppflags if necessary. > Done. > >> - grub_disk_addr_t *outaddr, grub_size_t *outsize, >> + grub_disk_addr_t * outaddr, grub_size_t * outsize, >> this is a stylistic regression. (several such occurences) >> - if (desc->data[desc->depth - 1].iter >> - < desc->data[desc->depth - 1].maxiter) >> + if (desc->data[desc->depth - 1].iter < >> + desc->data[desc->depth - 1].maxiter) >> Likewise. > Oops. Fixed. > >> + grub_uint8_t context[lzopio->ccheck_fun->contextsize]; >> This isn't necessarily well-aligned. Use grub_uint64_t >> context[(lzopio->ccheck_fun->contextsize + 7) / 8]; >> (several occurences) > Done. > >> + file->size =3D GRUB_FILE_SIZE_UNKNOWN; >> Several components have trouble with such files. Is there any way to >> retrieve the size of lzio compressed file? > It is possible and it is already implemented, please see=20 > calculate_uncompressed_size(). Actually, uncompressed size is always=20 > calculated. There is TODO to not do it on not-easily-seekable files as = done in=20 > other ios. And GRUB_FILE_SIZE_UNKNOWN is set for 'future proof' only. > >>> - lzopio works ok with grub-fstest (crc, testload), also able to load= >>> modules >>> >>> compressed with lzop, but compressing all modules and doing >>> grub-install --modules=3Dlzopio fails to boot, still need to invest= igate >>> that >> That because dependencies on hashes are soft so it's not correctly >> tracked by grub-install and so you end up in an infinite recursion. > > Branch on savannah updated. > --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigCFE34AFA5BB5E817DCB848A1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk6NwjEACgkQNak7dOguQgkc0gD+MSGX3o6IjcdSBB4Pk3QPruFQ 1JinIgjAcHy70bx7rusA/3+ljLAXGn57wk1YBomxthUVceRsbfWn020f+pziMIaS =1ZQ2 -----END PGP SIGNATURE----- --------------enigCFE34AFA5BB5E817DCB848A1--