From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RBqlU-0001hs-9n
	for qemu-devel@nongnu.org; Thu, 06 Oct 2011 12:25:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RBqlT-0006M0-Bs
	for qemu-devel@nongnu.org; Thu, 06 Oct 2011 12:25:44 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:60244)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RBqlT-0006LA-7K
	for qemu-devel@nongnu.org; Thu, 06 Oct 2011 12:25:43 -0400
Message-ID: <4E8DD650.9060106@weilnetz.de>
Date: Thu, 06 Oct 2011 18:24:48 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] [RFC] Use TCGReg for all TCG targets?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>, Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>

Hi,

commit 48bb3750e13cbb5a634d3aeab5191d74d124232f
introduced the data type 'TCGReg' in tcg/s390.

Today, s390 is the only TCG target which uses TCGReg.

This causes a conflict with my commit
c0ad3001bf12292b137b05e1c4643f31c6b0a727,
because some function prototypes in tcg/s390/tcg-target.c
differ from those in all the other TCG targets.
Builds on s390 hosts are broken now.

I'd like to use TCGReg in all TCG targets, thus fixing the
conflict and improving readability of the code
('TCGReg' is more specific than 'int').

Is there consensus that this is a good idea, or should
TCGReg be removed (then all TCG targets use int) or only
used for s390?

I cc'ed all TCG maintainers because their code would
have to be changed.

Regards,
Stefan Weil