From: Paolo Bonzini <pbonzini@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()
Date: Thu, 06 Oct 2011 18:26:15 +0200 [thread overview]
Message-ID: <4E8DD6A7.7050404@redhat.com> (raw)
In-Reply-To: <49696d43bab6d485d414cfe58772c9ac54926b63.1317911543.git.quintela@redhat.com>
On 10/06/2011 06:21 PM, Juan Quintela wrote:
> + result = qemu_peek_byte(f);
> +
> + if (f->buf_index< f->buf_size) {
> + f->buf_index++;
> }
This should really be an assert that f->buf_index < f->buf_size,
otherwise qemu_peek_byte has read garbage.
Paolo
next prev parent reply other threads:[~2011-10-06 16:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 16:21 [Qemu-devel] [PATCH 0/5] migration: Improve subsections detection Juan Quintela
2011-10-06 16:21 ` [Qemu-devel] [PATCH 1/5] savevm: teach qemu_fill_buffer to do partial refills Juan Quintela
2011-10-06 16:21 ` [Qemu-devel] [PATCH 2/5] savevm: some coding style cleanups Juan Quintela
2011-10-06 16:21 ` [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte() Juan Quintela
2011-10-06 16:26 ` Paolo Bonzini [this message]
2011-10-06 22:40 ` Juan Quintela
2011-10-06 16:21 ` [Qemu-devel] [PATCH 4/5] savevm: improve subsections detection on load Juan Quintela
2011-10-06 16:26 ` Paolo Bonzini
2011-10-06 22:42 ` Juan Quintela
2011-10-07 6:37 ` Paolo Bonzini
2011-10-06 16:21 ` [Qemu-devel] [PATCH 5/5] Revert "savevm: fix corruption in vmstate_subsection_load()." Juan Quintela
-- strict thread matches above, loose matches on Subject: below --
2011-10-07 10:53 [Qemu-devel] [PATCH v3 0/5] migration: Improve subsections detection Juan Quintela
2011-10-07 10:53 ` [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte() Juan Quintela
2011-10-09 19:49 [Qemu-devel] [PATCH v4 0/5] Improve subsections detection Juan Quintela
2011-10-09 19:50 ` [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte() Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8DD6A7.7050404@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.