From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] powerpc/85xx: wait for alignment before resetting SERDES RX lanes (SERDES9)
Date: Thu, 6 Oct 2011 16:07:13 -0500 [thread overview]
Message-ID: <4E8E1881.5030902@freescale.com> (raw)
In-Reply-To: <20111006210355.C10BC140874A@gemini.denx.de>
Wolfgang Denk wrote:
> WARNING: externs should be avoided in .c files
> #114: FILE: board/freescale/corenet_ds/eth_p4080.c:100:
> + extern struct phy_driver tn2020_driver;
This is intentional. There's no header file for the teranetics driver, and
referencing the structure allows me to avoid a hard-coded number.
Are you suggesting that I create a header file just to contain this line:
extern struct phy_driver tn2020_driver;
because that seems silly.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-10-06 21:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 19:00 [U-Boot] [PATCH 1/3] phylib: Work around bug in Teranetics PHY Timur Tabi
2011-10-05 19:00 ` [U-Boot] [PATCH 2/3] phylib: wait for TN2020 to achieve SERDES lane alignment at startup Timur Tabi
2011-10-05 19:00 ` [U-Boot] [PATCH 3/3] powerpc/85xx: wait for alignment before resetting SERDES RX lanes (SERDES9) Timur Tabi
2011-10-06 21:03 ` Wolfgang Denk
2011-10-06 21:07 ` Timur Tabi [this message]
2011-10-06 22:21 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8E1881.5030902@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.