All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: Reinhard Tartler <Reinhard.Tartler@informatik.uni-erlangen.de>
Cc: linux-kbuild@vger.kernel.org, Jean Sacren <sakiwit@gmail.com>,
	Michal Marek <mmarek@suse.cz>,
	linux-kernel@vger.kernel.org,
	vamos-dev@lists.informatik.uni-erlangen.de
Subject: Re: [PATCH] kconfig: Fix checking return value of 'fwrite'
Date: Fri, 07 Oct 2011 10:34:33 +0800	[thread overview]
Message-ID: <4E8E6539.2030809@redhat.com> (raw)
In-Reply-To: <87lisype1v.fsf@faui43f.informatik.uni-erlangen.de>

于 2011年10月06日 19:14, Reinhard Tartler 写道:
> fwrite indicates '1' written member if a zero-length string is written.

For completeness, xfwrite() is called like this,

         xfwrite(str, strlen(str), 1, data);

so if strlen() returns 0, xfwrite() will print out the error message,
which is wrong, no error in this case.

Acked-by: WANG Cong <amwang@redhat.com>

Thanks!

  reply	other threads:[~2011-10-07  2:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06 11:14 [PATCH] kconfig: Fix checking return value of 'fwrite' Reinhard Tartler
2011-10-07  2:34 ` Cong Wang [this message]
2011-10-07  3:29 ` Arnaud Lacombe
2011-11-20 13:24   ` Michal Marek
2011-11-20 15:53     ` Reinhard Tartler
2011-11-23  5:53     ` Jean Sacren
2011-11-23  6:30       ` Reinhard Tartler
2011-11-23 18:05         ` Arnaud Lacombe
2011-11-25 23:42           ` [PATCH] kbuild: Fix compiler warning with assertion when calling 'fwrite' Jean Sacren
2012-01-14 23:19             ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8E6539.2030809@redhat.com \
    --to=amwang@redhat.com \
    --cc=Reinhard.Tartler@informatik.uni-erlangen.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sakiwit@gmail.com \
    --cc=vamos-dev@lists.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.