From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm, post, memory: fix bug if sdram base != 0x00000000
Date: Fri, 07 Oct 2011 08:53:59 +0200 [thread overview]
Message-ID: <4E8EA207.90401@keymile.com> (raw)
In-Reply-To: <1317969600-32496-1-git-send-email-hs@denx.de>
On 10/07/2011 08:40 AM, Heiko Schocher wrote:
> commit 8d3fcb5e60b6c8e1d530dbc2e2e33ec6a44670da breaks post
> memory support for sdram base != 0x00000000. Fix this.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> Cc: Holger Brunck <holger.brunck@keymile.com>
> ---
> $ /home/git/linux-denx/scripts/checkpatch.pl 0001-arm-post-memory-fix-bug-if-sdram-base-0x00000000.patch
> total: 0 errors, 0 warnings, 14 lines checked
>
> 0001-arm-post-memory-fix-bug-if-sdram-base-0x00000000.patch has no obvious style problems and is ready for submission.
>
> post/drivers/memory.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/post/drivers/memory.c b/post/drivers/memory.c
> index 69973c0..d25e323 100644
> --- a/post/drivers/memory.c
> +++ b/post/drivers/memory.c
> @@ -466,10 +466,11 @@ static int memory_post_test_regions(unsigned long start, unsigned long size)
>
> for (i = 0; i < (size >> 20) && (!ret); i++) {
> if (!ret)
> - ret = memory_post_test_patterns(i << 20, 0x800);
> - if (!ret)
> - ret = memory_post_test_patterns((i << 20) + 0xff800,
> + ret = memory_post_test_patterns(start + (i << 20),
> 0x800);
> + if (!ret)
> + ret = memory_post_test_patterns(start + (i << 20) +
> + 0xff800, 0x800);
> }
>
> return ret;
Thanks for fixing that Heiko: we only have boards starting @0x00000000 so I did
not notice this bug.
Ackey-by: Valentin Longchamp <valentin.longchamp@keymile.com>
Valentin
next prev parent reply other threads:[~2011-10-07 6:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 6:40 [U-Boot] [PATCH] arm, post, memory: fix bug if sdram base != 0x00000000 Heiko Schocher
2011-10-07 6:53 ` Valentin Longchamp [this message]
2011-10-07 17:19 ` Mike Frysinger
2011-10-23 20:14 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8EA207.90401@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.