From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42114)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RC5td-0004X5-7l
	for qemu-devel@nongnu.org; Fri, 07 Oct 2011 04:35:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RC5tb-0000od-F1
	for qemu-devel@nongnu.org; Fri, 07 Oct 2011 04:35:09 -0400
Received: from goliath.siemens.de ([192.35.17.28]:17594)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RC5tb-0000lh-1T
	for qemu-devel@nongnu.org; Fri, 07 Oct 2011 04:35:07 -0400
Message-ID: <4E8EB9B7.4000007@siemens.com>
Date: Fri, 07 Oct 2011 10:35:03 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <CAJ+d0T0s5f7ADykxrZoHneRZgJLNPsscxS_-k8MwzybJ3rT7jg@mail.gmail.com>
In-Reply-To: <CAJ+d0T0s5f7ADykxrZoHneRZgJLNPsscxS_-k8MwzybJ3rT7jg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Integrating Dynamips and GNS3 UDP tunnels (Patches)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Epitech <mlspirat42@gmail.com>
Cc: qemu-devel@nongnu.org

On 2011-10-06 19:08, Benjamin Epitech wrote:
> GNS3 team developed a GUI in order to inter-connect different emulated
> hardware. In order
> to achieve a network inter-connection between each hosts, one single
> protocol is used: an
> UDP tunneling protocol introduced by Dynamips (a cisco hardware emulator).
> 
> Since the beginning, GNS3 supports Qemu by providing patches for its users,
> these patches
> bring to Qemu the implementation of Dynamips UDP tunneling protocol.
> 
> As GNS3 improves and now supports VirtualBox, it should be time to free
> users of the assle
> of having to patch Qemu themselves. FreeBSD integrated our patches in the
> ports tree, we
> ship a patched Qemu for Windows, and we're now looking forward to integrate
> those patches
> upstream.
> 
> Here are the patches that apply on the latest release of Qemu, I hereby
> submit them for your
> approval or not.
> 
> 1) Basic patch in order to build the new source file
> http://code.gns3.net/qemu-patches/file/6a927b6cdaf8/Makefile_objs.patch
> 
> 2) Parse -net udp
> http://code.gns3.net/qemu-patches/file/6a927b6cdaf8/net_c.patch
> 
> 3) New NET_CLIENT_TYPE_UDP macro
> http://code.gns3.net/qemu-patches/file/6a927b6cdaf8/net_h.patch
> 
> 4) New source code file, implementation of the UDP tunneling protocol
> http://code.gns3.net/qemu-patches/file/6a927b6cdaf8/net_udp_c.patch
> 
> 5) Corresponding header file
> http://code.gns3.net/qemu-patches/file/6a927b6cdaf8/net_udp_h.patch
> 
> The hw_e1000_c.patch is no longer needed, it was a dirty hack that we kept
> for too long.
> The block_raw-win32_c.patch fixes a minor issue that arises only on Windows,
> it may deserve
> another topic.
> 
> Please include me in the replies as I am not subscribed to the list.
> 

You should send out the changes as proper patch series, rebased on
current git head. See http://wiki.qemu.org/Contribute/SubmitAPatch for
further requirements. And make sure that no patch breaks the build so
that bisectability is preserved.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux