All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thomas@shipmail.org>
To: "Marek Olšák" <maraeo@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/ttm: add a way to bo_wait for either the last read or	last write
Date: Fri, 07 Oct 2011 10:58:13 +0200	[thread overview]
Message-ID: <4E8EBF25.5000502@shipmail.org> (raw)
In-Reply-To: <1312749544-22052-1-git-send-email-maraeo@gmail.com>

Oh, and one more style comment below:

On 08/07/2011 10:39 PM, Marek Olšák wrote:
>
> +enum ttm_buffer_usage {
> +    TTM_USAGE_READ = 1,
> +    TTM_USAGE_WRITE = 2,
> +    TTM_USAGE_READWRITE = TTM_USAGE_READ | TTM_USAGE_WRITE
> +};
>
>    

Please don't use enums for bit operations.

#define TTM_USAGE_FLAG_READ   (1 << 0)
#define TTM_USAGE_FLAG_WRITE  (1 << 1)

/Thomas



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2011-10-07  9:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-07 20:39 [PATCH 1/2] drm/ttm: add a way to bo_wait for either the last read or last write Marek Olšák
2011-08-07 20:39 ` [PATCH 2/2] drm/radeon/kms: add a new gem_wait ioctl with read/write flags Marek Olšák
2011-08-12 17:22   ` Jerome Glisse
2011-08-12 17:21 ` [PATCH 1/2] drm/ttm: add a way to bo_wait for either the last read or last write Jerome Glisse
2011-08-13 20:32   ` Marek Olšák
2011-10-04 11:48 ` Thomas Hellstrom
2011-10-05  2:08   ` Marek Olšák
2011-10-05  5:54     ` Thomas Hellstrom
2011-10-06 22:42       ` Marek Olšák
2011-10-07  8:00         ` Thomas Hellstrom
2011-10-07 13:24           ` Alex Deucher
2011-10-07 14:05             ` Thomas Hellstrom
2011-10-07 14:14               ` Alex Deucher
2011-10-07 13:38           ` Jerome Glisse
2011-10-07 13:42             ` Jerome Glisse
2011-10-07 21:07               ` Marek Olšák
2011-10-07 14:09             ` Thomas Hellstrom
2011-10-07 21:30             ` Marek Olšák
2011-10-08  8:14               ` Thomas Hellstrom
2011-10-07 22:03           ` Marek Olšák
2011-10-24 14:48             ` Thomas Hellstrom
2011-10-24 17:10               ` Marek Olšák
2011-10-24 17:28                 ` Thomas Hellstrom
2011-10-24 17:39                   ` Marek Olšák
2011-10-07  8:58 ` Thomas Hellstrom [this message]
2011-10-08 10:26   ` Ville Syrjälä
2011-10-08 11:10     ` Thomas Hellstrom
2011-10-08 11:27       ` Ville Syrjälä
2011-10-08 11:32         ` Thomas Hellstrom
2011-10-24 16:42           ` Marek Olšák
2011-10-24 16:47             ` Thomas Hellstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8EBF25.5000502@shipmail.org \
    --to=thomas@shipmail.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maraeo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.