Re: [PATCH 3/4] ARM: Exynos4: enable TV support on Universal_C210 board

[Tomasz Stanislawski <t.stanislaws@samsung.com>]

Hi Sachin Kamat,
The "hdmi-en" regulator was used to enable DC-DC converter(s).
The converters supply HDMI hardware or produce 5V for HDMI connector. 
According to Origen schematics 'DC5V' line is used to supply 5V to HDMI 
connector. Therefore regulator 'hdmi-en' refers to the regulator 
associated with 'DC5V' line. If the 'DC5V' regulator is not present in 
mach-origen.c (???) then 'hdmi-en' becomes a dummy regulator.

Try to enable REGULATOR_DUMMY in kernel config.

The regulator framework would associate a dummy regulator to 'hdmi-en' 
if it fails to find it.

I hope you find this information useful.

Best regards,
Tomasz Stanislawski


On 10/07/2011 12:00 PM, Sachin Kamat wrote:
> Hi Tomasz,
> What is the significance of "hdmi-en" as a regulator? Is this specific
> to your board.
> I am unable to relate the GPIO pin corresponding to it on Origen board.
> Thanks and regards
> Sachin
>
> On 12 August 2011 15:15, Tomasz Stanislawski <t.stanislaws@samsung.com
> <mailto:t.stanislaws@samsung.com>> wrote:
>
>     This patch adds platform devices and regulators for TV devices on
>     Samsung Universal C210 board.
>
>     Signed-off-by: Tomasz Stanislawski <t.stanislaws@samsung.com
>     <mailto:t.stanislaws@samsung.com>>
>     Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com
>     <mailto:kyungmin.park@samsung.com>>
>     Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com
>     <mailto:m.szyprowski@samsung.com>>
>     ---
>       arch/arm/mach-exynos4/Kconfig               |    2 +
>       arch/arm/mach-exynos4/mach-universal_c210.c |   74
>     +++++++++++++++++++++++++++
>       2 files changed, 76 insertions(+), 0 deletions(-)
>
>     diff --git a/arch/arm/mach-exynos4/Kconfig
>     b/arch/arm/mach-exynos4/Kconfig
>     index 3ceefdb..144c05d 100644
>     --- a/arch/arm/mach-exynos4/Kconfig
>     +++ b/arch/arm/mach-exynos4/Kconfig
>     @@ -184,9 +184,11 @@ config MACH_UNIVERSAL_C210
>             select S3C_DEV_I2C1
>             select S3C_DEV_I2C3
>             select S3C_DEV_I2C5
>     +       select S5P_DEV_I2C_HDMIPHY
>             select S5P_DEV_MFC
>             select S5P_DEV_ONENAND
>             select EXYNOS4_DEV_PD
>     +       select S5P_DEV_TV
>             select EXYNOS4_SETUP_I2C1
>             select EXYNOS4_SETUP_I2C3
>             select EXYNOS4_SETUP_I2C5
>     diff --git a/arch/arm/mach-exynos4/mach-universal_c210.c
>     b/arch/arm/mach-exynos4/mach-universal_c210.c
>     index 0e280d1..e9dbe79 100644
>     --- a/arch/arm/mach-exynos4/mach-universal_c210.c
>     +++ b/arch/arm/mach-exynos4/mach-universal_c210.c
>     @@ -110,6 +110,9 @@ static struct regulator_consumer_supply
>     lp3974_buck1_consumer =
>       static struct regulator_consumer_supply lp3974_buck2_consumer =
>             REGULATOR_SUPPLY("vddg3d", NULL);
>
>     +static struct regulator_consumer_supply lp3974_buck3_consumer =
>     +       REGULATOR_SUPPLY("vdet", "s5p-sdo");
>     +
>       static struct regulator_init_data lp3974_buck1_data = {
>             .constraints    = {
>                     .name           = "VINT_1.1V",
>     @@ -153,6 +156,8 @@ static struct regulator_init_data
>     lp3974_buck3_data = {
>                             .enabled        = 1,
>                     },
>             },
>     +       .num_consumer_supplies = 1,
>     +       .consumer_supplies = &lp3974_buck3_consumer,
>       };
>
>       static struct regulator_init_data lp3974_buck4_data = {
>     @@ -181,6 +186,11 @@ static struct regulator_init_data
>     lp3974_ldo2_data = {
>             },
>       };
>
>     +static struct regulator_consumer_supply lp3974_ldo3_consumer[] = {
>     +       REGULATOR_SUPPLY("vdd", "exynos4-hdmi"),
>     +       REGULATOR_SUPPLY("vdd_pll", "exynos4-hdmi"),
>     +};
>     +
>       static struct regulator_init_data lp3974_ldo3_data = {
>             .constraints    = {
>                     .name           = "VUSB+MIPI_1.1V",
>     @@ -192,6 +202,12 @@ static struct regulator_init_data
>     lp3974_ldo3_data = {
>                             .disabled       = 1,
>                     },
>             },
>     +       .num_consumer_supplies = ARRAY_SIZE(lp3974_ldo3_consumer),
>     +       .consumer_supplies = lp3974_ldo3_consumer,
>     +};
>     +
>     +static struct regulator_consumer_supply lp3974_ldo4_consumer[] = {
>     +       REGULATOR_SUPPLY("vdd_osc", "exynos4-hdmi"),
>       };
>
>       static struct regulator_init_data lp3974_ldo4_data = {
>     @@ -205,6 +221,8 @@ static struct regulator_init_data
>     lp3974_ldo4_data = {
>                             .disabled       = 1,
>                     },
>             },
>     +       .num_consumer_supplies = ARRAY_SIZE(lp3974_ldo4_consumer),
>     +       .consumer_supplies = lp3974_ldo4_consumer,
>       };
>
>       static struct regulator_init_data lp3974_ldo5_data = {
>     @@ -246,6 +264,10 @@ static struct regulator_init_data
>     lp3974_ldo7_data = {
>             },
>       };
>
>     +static struct regulator_consumer_supply lp3974_ldo8_consumer[] = {
>     +       REGULATOR_SUPPLY("vdd33a_dac", "s5p-sdo"),
>     +};
>     +
>       static struct regulator_init_data lp3974_ldo8_data = {
>             .constraints    = {
>                     .name           = "VUSB+VDAC_3.3V",
>     @@ -257,6 +279,8 @@ static struct regulator_init_data
>     lp3974_ldo8_data = {
>                             .disabled       = 1,
>                     },
>             },
>     +       .num_consumer_supplies = ARRAY_SIZE(lp3974_ldo8_consumer),
>     +       .consumer_supplies = lp3974_ldo8_consumer,
>       };
>
>       static struct regulator_init_data lp3974_ldo9_data = {
>     @@ -472,6 +496,34 @@ static struct max8998_platform_data
>     universal_lp3974_pdata = {
>             .wakeup                 = true,
>       };
>
>     +static struct regulator_consumer_supply hdmi_fixed_consumer =
>     +       REGULATOR_SUPPLY("hdmi-en", "exynos4-hdmi");
>     +
>     +static struct regulator_init_data hdmi_fixed_voltage_init_data = {
>     +       .constraints            = {
>     +               .name           = "HDMI_5V",
>     +               .valid_ops_mask = REGULATOR_CHANGE_STATUS,
>     +       },
>     +       .num_consumer_supplies  = 1,
>     +       .consumer_supplies      = &hdmi_fixed_consumer,
>     +};
>     +
>     +static struct fixed_voltage_config hdmi_fixed_voltage_config = {
>     +       .supply_name            = "HDMI_EN1",
>     +       .microvolts             = 5000000,
>     +       .gpio                   = EXYNOS4_GPE0(1),
>     +       .enable_high            = true,
>     +       .init_data              = &hdmi_fixed_voltage_init_data,
>     +};
>     +
>     +static struct platform_device hdmi_fixed_voltage = {
>     +       .name                   = "reg-fixed-voltage",
>     +       .id                     = 6,
>     +       .dev                    = {
>     +               .platform_data  = &hdmi_fixed_voltage_config,
>     +       },
>     +};
>     +
>       /* GPIO I2C 5 (PMIC) */
>       static struct i2c_board_info i2c5_devs[] __initdata = {
>             {
>     @@ -714,6 +766,12 @@ static struct platform_device
>     *universal_devices[] __initdata = {
>     &s3c_device_hsmmc3,
>     &s3c_device_i2c3,
>     &s3c_device_i2c5,
>     + &s5p_device_i2c_hdmiphy,
>     + &hdmi_fixed_voltage,
>     + &exynos4_device_pd[PD_TV],
>     + &s5p_device_hdmi,
>     + &s5p_device_sdo,
>     + &s5p_device_mixer,
>
>             /* Universal Devices */
>     &i2c_gpio12,
>     @@ -732,6 +790,20 @@ static void __init universal_map_io(void)
>             s3c24xx_init_uarts(universal_uartcfgs,
>     ARRAY_SIZE(universal_uartcfgs));
>       }
>
>     +void s5p_tv_setup(void)
>     +{
>     +       /* direct HPD to HDMI chip */
>     +       gpio_request(EXYNOS4_GPX3(7), "hpd-plug");
>     +
>     +       gpio_direction_input(EXYNOS4_GPX3(7));
>     +       s3c_gpio_cfgpin(EXYNOS4_GPX3(7), S3C_GPIO_SFN(0x3));
>     +       s3c_gpio_setpull(EXYNOS4_GPX3(7), S3C_GPIO_PULL_NONE);
>     +
>     +       /* setup dependencies between TV devices */
>     +       s5p_device_hdmi.dev.parent = &exynos4_device_pd[PD_TV].dev;
>     +       s5p_device_mixer.dev.parent = &exynos4_device_pd[PD_TV].dev;
>     +}
>     +
>       static void __init universal_reserve(void)
>       {
>             s5p_mfc_reserve_mem(0x43000000, 8 << 20, 0x51000000, 8 << 20);
>     @@ -740,6 +812,7 @@ static void __init universal_reserve(void)
>       static void __init universal_machine_init(void)
>       {
>             universal_sdhci_init();
>     +       s5p_tv_setup();
>
>             i2c_register_board_info(0, i2c0_devs, ARRAY_SIZE(i2c0_devs));
>             i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs));
>     @@ -749,6 +822,7 @@ static void __init universal_machine_init(void)
>             i2c_register_board_info(3, i2c3_devs, ARRAY_SIZE(i2c3_devs));
>
>             s3c_i2c5_set_platdata(NULL);
>     +       s5p_i2c_hdmiphy_set_platdata(NULL);
>             i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs));
>
>             universal_touchkey_init();
>     --
>     1.7.6
>
>     --
>     To unsubscribe from this list: send the line "unsubscribe
>     linux-samsung-soc" in
>     the body of a message to majordomo@vger.kernel.org
>     <mailto:majordomo@vger.kernel.org>
>     More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
>
> --
> With warm regards,
> Sachin
>