From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: balbi@ti.com
Cc: Klaus Schwarzkopf <schwarzkopf@sensortherm.de>,
gregkh@suse.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: add new usb gadget for ACM and mass storage
Date: Fri, 07 Oct 2011 15:13:50 +0400 [thread overview]
Message-ID: <4E8EDEEE.2090907@ru.mvista.com> (raw)
In-Reply-To: <20111007101414.GN10910@legolas.emea.dhcp.ti.com>
On 07.10.2011 14:14, Felipe Balbi wrote:
>>>>>> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
>>>>>> index dd1571d..f623f3d 100644
>>>>>> --- a/include/linux/usb/gadget.h
>>>>>> +++ b/include/linux/usb/gadget.h
>>>>>> @@ -15,6 +15,7 @@
>>>>>> #ifndef __LINUX_USB_GADGET_H
>>>>>> #define __LINUX_USB_GADGET_H
>>>>>>
>>>>>> +#include<linux/device.h>
>>>>> this is not part of $SUBJECT
>>>> changed git message
>>> not enough. adding another header is not part of this patch. You need to
>>> let us know why you need this new header there and you need add proper
>>> spacing there.
>> There is a space in the orginal patch.
>> Should i make a seperate patch for this?
>> In the header gadget.h are some stuff used, but not declared.
>> My compile errors without device.h:
>> CC drivers/usb/gadget/acm_ms.o
>> In file included from include/linux/usb/composite.h:38,
>> from drivers/usb/gadget/u_serial.h:15,
>> from drivers/usb/gadget/acm_ms.c:20:
>> include/linux/usb/gadget.h:491: error: field ‘dev’ has incomplete type
>> include/linux/usb/gadget.h: In function ‘set_gadget_data’:
>> include/linux/usb/gadget.h:495: error: implicit declaration of
>> function ‘dev_set_drvdata’
>> include/linux/usb/gadget.h: In function ‘get_gadget_data’:
>> include/linux/usb/gadget.h:497: error: implicit declaration of
>> function ‘dev_get_drvdata’
>> include/linux/usb/gadget.h: In function ‘dev_to_usb_gadget’:
>> include/linux/usb/gadget.h:500: warning: type defaults to ‘int’ in
>> declaration of ‘__mptr’
>> include/linux/usb/gadget.h:500: warning: initialization from
>> incompatible pointer type
>> include/linux/usb/gadget.h: At top level:
>> include/linux/usb/gadget.h:781: error: field ‘driver’ has incomplete type
>> In file included from drivers/usb/gadget/composite.c:26,
>> from drivers/usb/gadget/acm_ms.c:44:
>> include/linux/device.h:705: error: conflicting types for ‘dev_get_drvdata’
>> include/linux/usb/gadget.h:497: note: previous implicit declaration
>> of ‘dev_get_drvdata’ was here
>> In file included from drivers/usb/gadget/acm_ms.c:44:
>> drivers/usb/gadget/composite.c:1261: error: field name not in record
>> or union initializer
>> drivers/usb/gadget/composite.c:1261: error: (near initialization for
>> ‘composite_driver.driver’)
>> make[3]: *** [drivers/usb/gadget/acm_ms.o] Error 1
>> make[2]: *** [drivers/usb/gadget] Error 2
>> make[1]: *** [drivers/usb] Error 2
>> make: *** [drivers] Error 2
> I believe Sergei had that patch already, but it wasn't applied for some
> reason. Sergei, do you happen to remember the outcome of that patch ?
It has been apllied allright to 3.1-rc1. :-)
WBR, Sergei
next prev parent reply other threads:[~2011-10-07 11:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 18:24 [PATCH] usb: add new usb gadget for ACM and mass storage Klaus Schwarzkopf
2011-09-08 19:11 ` Greg KH
2011-09-09 8:37 ` Klaus Schwarzkopf
2011-09-09 10:30 ` Michal Nazarewicz
2011-09-09 18:45 ` Greg KH
2011-09-09 10:20 ` Michal Nazarewicz
2011-09-09 18:43 ` Greg KH
2011-09-16 17:18 ` Sebastian Andrzej Siewior
2011-09-16 17:25 ` Greg KH
2011-09-16 17:30 ` Michal Nazarewicz
2011-09-16 18:22 ` Steve Calfee
2011-09-16 18:55 ` Sebastian Andrzej Siewior
2011-09-16 21:22 ` Alan Stern
2011-10-06 12:08 ` Felipe Balbi
2011-10-07 8:23 ` Klaus Schwarzkopf
2011-10-07 8:38 ` Felipe Balbi
2011-10-07 10:07 ` Klaus Schwarzkopf
2011-10-07 10:14 ` Felipe Balbi
2011-10-07 11:13 ` Sergei Shtylyov [this message]
2011-10-07 12:55 ` Felipe Balbi
2011-10-07 11:11 ` Sergei Shtylyov
2011-10-07 8:16 ` [PATCH v2] " Klaus Schwarzkopf
2011-10-07 8:39 ` Felipe Balbi
2011-10-08 7:44 ` [PATCH v3] " Klaus Schwarzkopf
2011-10-10 5:50 ` Felipe Balbi
2011-10-10 8:33 ` Klaus Schwarzkopf
2011-10-10 8:49 ` Felipe Balbi
2011-10-10 10:30 ` Klaus Schwarzkopf
2011-10-10 15:14 ` Alan Stern
2011-10-10 16:00 ` Michal Nazarewicz
2011-10-10 8:32 ` [PATCH v4] " Klaus Schwarzkopf
2011-10-13 17:43 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8EDEEE.2090907@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=schwarzkopf@sensortherm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.